Fixed tests and lint problems in windows #515
Conversation
flight/template/View.php
Outdated
| @@ -130,6 +130,7 @@ public function render($file, $data = null) | |||
| $this->template = $this->getTemplate($file); | |||
|
|
|||
| if (!file_exists($this->template)) { | |||
| $this->template = self::normalizePath($this->template); | |||
There was a problem hiding this comment.
So this will fix the path....but then it throws an exception so nothing is really fixed.
There was a problem hiding this comment.
Do you mean about empty strings?
tests/ViewTest.php
Outdated
| } | ||
| }; | ||
|
|
||
| self::assertSame( |
There was a problem hiding this comment.
Not a huge deal but the rest of the file uses $this-> instead of self:: One thing I've learned that is really important is to keep the codebase as consistent as possible so it doesn't look like "Oh that's definitely a spot fadrian06 coded in". When I code in this framework, even though it drives me nuts, I keep all the class vars lowercase. I would much rather do $Router = Flight::router(); but in order to keep it consistent, I do $router = Flight::router(); simply because it's keeping it consistent.
There was a problem hiding this comment.
oh sorry, I hadn't noticed
No description provided.