Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced some docblocks to native PHP 7.4 typehint #528

Merged
merged 12 commits into from
Jan 25, 2024
Merged

Replaced some docblocks to native PHP 7.4 typehint #528

merged 12 commits into from
Jan 25, 2024

Conversation

fadrian06
Copy link
Contributor

@fadrian06 fadrian06 commented Jan 24, 2024 •
edited

image
image

NOTE:
There are some inconsistences in docblocks code-style that I like to fix in another PR

@fadrian06 fadrian06 marked this pull request as ready for review January 24, 2024 20:22
@krmu krmu self-assigned this Jan 24, 2024
krmu
krmu approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@krmu krmu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅
@n0nag0n

@n0nag0n n0nag0n merged commit 0d7b79b into master Jan 25, 2024
@n0nag0n n0nag0n deleted the add-typehint branch January 25, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krmu krmu krmu approved these changes

Assignees

@krmu krmu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fadrian06 @krmu @n0nag0n