Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed bug with root alias #534

Merged
merged 2 commits into from
Jan 28, 2024
Merged

fixed bug with root alias #534

merged 2 commits into from
Jan 28, 2024

Conversation

n0nag0n
Copy link
Collaborator

@n0nag0n n0nag0n commented Jan 28, 2024

No description provided.

@n0nag0n
Copy link
Collaborator Author

n0nag0n commented Jan 28, 2024

This would return '' for an alias if it was the / path

fadrian06
fadrian06 approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@fadrian06 fadrian06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does your editor use tabs instead of spaces? I have already noticed it from several commits

@n0nag0n
Copy link
Collaborator Author

n0nag0n commented Jan 28, 2024

Gah, yeah I keep switching it. Lemme fix it.

@n0nag0n n0nag0n merged commit 19e40b9 into master Jan 28, 2024
@n0nag0n n0nag0n deleted the alias-bug branch January 28, 2024 03:02
@fadrian06
Copy link
Contributor

It's strange, that's why I set the .editorconfig to follow the spaces by tabs, I also preferred tabs, but on github it makes it difficult to read the diff because each tab gives 4 spaces and I have 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadrian06 fadrian06 fadrian06 approved these changes

@krmu krmu Awaiting requested review from krmu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n0nag0n @fadrian06