Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix testStaticFunctionMapping to actually map a static method #535

Conversation

lubiana
Copy link

@lubiana lubiana commented Jan 30, 2024

The test was violating phps strict_types, did not test what the name suggested, and was failing.

Copy link
Collaborator

@n0nag0n n0nag0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@n0nag0n n0nag0n merged commit d946452 into flightphp:master Jan 30, 2024
@lubiana lubiana deleted the fix_dispatcher_test_testStaticFunctionMapping branch January 30, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants