This repository has been archived by the owner on Apr 28, 2021. It is now read-only.
Link flags #17
Merged
Link flags #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the ADD_LINK_FLAG macro to store flags in the EXTRA_LDFLAGS variable if none is provided. Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
Previously this was only used to link the example enclave. Using it everywhere makes a lot more sense. Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
Likely CODE_COVERAGE_CFLAGS and CODE_COVERAGE_CXXFLAGS are the same. Still this is good form. Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
Enabling 'defs' and 'code-coverage' at the same time causes the link operation to fail with an undefined reference from __gcov_init to 'atexit'. For simplicity this patch will only enable the 'defs' linker option if code coverage is disabled. Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.