feat: add judge about fetchUrl is required in DeployReload

flingyp · Jan 16, 2024 · a8a132b · a8a132b
1 parent eeb61b9
commit a8a132b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/RouterContent.vue b/src/RouterContent.vue
@@ -24,7 +24,8 @@ const isOpenDialog = ref(true);
 const { isOpenDeployReload } = storeToRefs(useVAdmireConfigStore());
 
 const deployReload = new DeployReload({
-  fetchUrl: 'http://localhost:4173/config.json',
+  // TIP: Config interface url to get 'fetchKey' value
+  fetchUrl: '',
   fetchKey: 'buildTime',
   isListening: false,
   checkTimeout: 60 * 5,

diff --git a/src/utils/reload.ts b/src/utils/reload.ts
@@ -28,6 +28,10 @@ export class DeployReload {
 
   constructor(options: DeployReloadOptions) {
     this.fetchUrl = options.fetchUrl;
+    if (!this.fetchUrl) {
+      console.error('fetchUrl is required in DeployReload');
+    }
+
     this.fetchKey = options.fetchKey;
     this.isListening = options.isListening || true;
     this.checkTimeout = options.checkTimeout || 5;
@@ -65,7 +69,7 @@ export class DeployReload {
   }
 
   private async checkBuildTime() {
-    if (this.isListening) {
+    if (this.isListening && this.fetchUrl) {
       const currentBuildTime = await this.getBuildTimeValue();
       if (currentBuildTime > this.stashBuildTime) {
         this.reloadCallback();