Provide candidates when function is called using incompatible caller capabilities #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklinsch
force-pushed
the
better-suited-candidates
branch
from
abe0664
to
2877333
Compare
franklinsch
added a commit
that referenced
this pull request
Feb 7, 2018
Provide candidates when function is called using incompatible caller capabilities
SusanEisenbach
pushed a commit
that referenced
this pull request
Jan 17, 2019
* [WIP] External traits (#71) * ABNF syntax for external traits * Add external token into Sources/Lexer/Token.swift * Parse new token in Sources/Lexer/Lexer.swift * Extend Sources/Parser/Parser+Declaration.swift (parseTopLevelDeclarations, parseTraitDeclaration) * Add tests to Tests/ParserTests * Change vim plugin to reflect external * Parse if let statements (#69) Parsing if let statements * Parse do-catch statements (#68) * ABNF grammar for do-catch statements * Add tokens do, catch, and is Token.swift * Add parser handling of do ... catch ... * Add tests * address review comments * Address scoping in doCatch * Fix post catch body scoping * Parse external calls (#70) * ABNF grammar for external calls * Adding backticks for consistency * Add call token and parse it in lexer * Add ExternalCall ASTNode * Parse external calls * Moved external trait test to Integration folder * Fix all target in Makefile * Added tests * Remove semicolon from Makefile * Add comment * Change variable name x to paramVisit * Remove unnecessary backticks for non-keywords * Introduce mode enum for external calls * Removed ASTPass.swift generated file * Address style changes for enum members * Prioritise external call on top of binary expression, inside parseExpression * Remove useless type function * Create PR * Add stubs and comments for changes required * Add external call semantic error messages * Add isInsideDo context variable * Add external call type checks * Remove from * Remove requirements reflecting changed proposal * Add stubs and comments for changes required * Add external call semantic error messages * Add isInsideDo context variable * Add external call type checks * Remove from * Remove requirements reflecting changed proposal * Add semantic checks * Merge external call semantic checks * Correct pass context for isInsideDoBlock variable * Move optional type external call variable declaration to BinaryExpression process function * Add accidentally deleted process(functionalCall, ...) function * Improve variable names and comment new error function * Remove isInsideIfCondition context element * Add external call in nested do-catch test * Replace isInsideDoCatch context variable by counter to support nested do-catches * Replace backticks with single quotation marks in error messages * Replace backticks with single quotation marks in test case * added semantic checks for external call hyperparameter types and usage (#106) Added semantic checks for correct hyperparameter types and usages regarding payable and non-payable functions. * Fix dot associativity (#116) * fix associativity of dot * fix linux not running all tests * fix function calls and variable dereferencing by adding new pass * fix linter errors in EnclosingTypeAssigner * add fix for loop variables * fix property ordering Properties were added to special declaration bodies in a different order to how they were declared. This probably isn't a problem right now, but might be a problem down the line so since I came across it I fixed it. * Revert "fix property ordering" This reverts commit d4917f4. * fix codegen for memory test, same issue as for ForStatement * update comments to be more descriptive * fix pivot op tokens * Implement casting parsing (#102) * work in progress – adding parsing for as as? as! * parse as * type conversions parser testing * fix linter issue * add semantic checks for as? as occurrence * wip compat check * add reinterpret checks + tests * add semantic analyzer tests and messages when types cannot be reinterpreted * add isSolidityType * fix tabs * ignore swp * fix external call type resolution and rename x-call flag * preliminary checks and diagnostic message * fix rebase isExternalCall => isExternalFunctionCall * correct ExternalCall visit not passing forward process result * fix type conversion tests * indicate kind when dumping AST of TCX * early return in default case for corrected enclosing type resolution in binary expressions * return true in isComplexStatement for x-calls and tcx * Add stubs and comments for changes required * Add external call semantic error messages * Add isInsideDo context variable * Add external call type checks * Remove from * Remove requirements reflecting changed proposal * Add semantic checks * Merge external call semantic checks * Correct pass context for isInsideDoBlock variable * Move optional type external call variable declaration to BinaryExpression process function * Improve variable names and comment new error function * Remove isInsideIfCondition context element * Add external call in nested do-catch test * Replace isInsideDoCatch context variable by counter to support nested do-catches * Replace backticks with single quotation marks in error messages * Replace backticks with single quotation marks in test case * Rebase * Merge
SusanEisenbach
pushed a commit
that referenced
this pull request
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #7.