Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test various configurations on CI #1241

Closed
fredrik-johansson opened this issue Mar 7, 2023 · 2 comments
Closed

Test various configurations on CI #1241

fredrik-johansson opened this issue Mar 7, 2023 · 2 comments

Comments

@fredrik-johansson
Copy link
Collaborator

fredrik-johansson commented Mar 7, 2023 •
edited
Loading

  • We should check with BLAS enabled on at least one platform.
  • We should test non-x86_64 architectures: at least x86_32, arm32 and arm64
@fredrik-johansson fredrik-johansson changed the title Test with BLAS on CI Test various configurations on CI Mar 21, 2023
@albinahlback
Copy link
Collaborator

BLAS now has a check.

It would be nice to test ARM64, but currently this is only available through slow emulations. We could do this only on pushes to trunk.

@albinahlback
Copy link
Collaborator

I think we have a good enough platform check. The only parts of FLINT that are architecture dependent are longlong.h and fft_small.h. Here longlong.h is checked under src/test, and this along with fft_small are tested whenever something changes here.

Personally, I think we can skip the ARM32 tests as they would rely on emulation. Will close this, but feel free to open if you think it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fredrik-johansson @albinahlback