Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use meson-python instead of setuptools for wheels #129

Merged
merged 52 commits into from
Apr 25, 2024

Conversation

oscarbenjamin
Copy link
Collaborator

This is just for wheel building for now and not building the dependencies.

Currently this works except on Windows and also there is a bug with meson-python and python 3.13.

@oscarbenjamin
Copy link
Collaborator Author

there is a bug with meson-python and python 3.13.

That bug is described in mesonbuild/meson#12401. It will be resolved somehow before Python 3.13 is released so it is not a significant problem.

@oscarbenjamin
Copy link
Collaborator Author

oscarbenjamin commented Mar 21, 2024

Okay, this is working on Windows now.

It is still not working with Flint < 3.1.0 for some reason...

@oscarbenjamin
Copy link
Collaborator Author

Since GitHub did not create the automatic back-reference this is where the rest of the discussion happened about these changes: mesonbuild/meson-python#602

@oscarbenjamin
Copy link
Collaborator Author

I've opened another discussion in meson-python about editable installs on OSX: mesonbuild/meson-python#604

@oscarbenjamin
Copy link
Collaborator Author

The main outstanding problem here is just that building with Flint < 3.1.0 fails when using pkgconfig. I think that this is due to a bug that was fixed by flintlib/flint#1647.

@oscarbenjamin
Copy link
Collaborator Author

I think that this is due to a bug that was fixed by flintlib/flint#1647.

I can confirm that fixing the Flint 3.0.1 flint.pc pkgconfig file fixes this problem. The question then is just whether python-flint should drop support for Flint < 3.0.1 or if it would be better to add something to the meson build config that can fix this.

@oscarbenjamin oscarbenjamin reopened this Apr 10, 2024
@oscarbenjamin oscarbenjamin reopened this Apr 21, 2024
@oscarbenjamin oscarbenjamin merged commit a65c88c into flintlib:master Apr 25, 2024
81 of 82 checks passed
@oscarbenjamin oscarbenjamin deleted the pr_meson_python branch April 25, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant