Skip to content
This repository has been archived by the owner on Sep 12, 2019. It is now read-only.

Update for swift 4 #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

christoff-1992
Copy link

As a result of updating the pod 'DataSource' the minimum target is now 9.0, however since we are now on iOS 11.x hopefully this shouldnt be an issue. 🤞

As a result of updating the pod 'DataSource' the minimum target is now 9.0, however since we are now on iOS 11.x this shouldnt be an issue. 🤞
@christoff-1992
Copy link
Author

christoff-1992 commented Apr 24, 2018

@flipacholas - I see the build has failed, however travis is targeting "osx_image": "xcode8", but due to updating 'DATASource' to 7.0.2 the minimum deployment target has been uplifted to iOS 9.0. Is this something that you would be happy with now that we are on iOS 11.X?

Also can I ask why are you returning the mainQueue for the test target?

private static func backgroundConcurrencyType() -> NSManagedObjectContextConcurrencyType {
        return TestCheck.isTesting ? .mainQueueConcurrencyType : .privateQueueConcurrencyType
    }

I have some of my own tests in my local project and this will return the wrong context, I can change this locally but is there any advantage if we require the privateQueue.

@flipacholas
Copy link
Owner

Thanks for your support! I'll try to review later next week since I'm tied up most of this one.

@@ -8,7 +8,7 @@

Pod::Spec.new do |s|
s.name = 'EncryptedDATAStack'
s.version = '7.0.3'
s.version = '8.0.0'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number is meant to be in sync with DataStack. I guess it could be changed to 7.0.3.1 to avoid any overlap.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entirely up to yourself :) @flipacholas - Thanks for taking a look I will leave the pull request for you to either close or accept after amending to suit your needs.

@flipacholas
Copy link
Owner

flipacholas commented Jun 2, 2018

I normally bring the project forward pulling the changes from DataStack, but since this is just meant to bring Swift 4 support I could merge it as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants