fix: fix Lumen v5.5 compatibility

[joelhy]

• fix fire method Lumen v5.5 compatibility

According to https://laravel.com/docs/5.5/upgrade, the fire method has been changed to handle in Lumen v5.5,
which break lumen-generator in Lumen v5.5.

In Laravel v5.4 Illuminate/Console/Command.php Line 180, there is handle method support:

$method = method_exists($this, 'handle') ? 'handle' : 'fire';

So it just need to change fire method name to handle.

• fix artisan route:list Lumen v5.5 compatibility

In Lumen v5.5 router methods is not directly attached to Application. To get Router object, we need to use $app->router.

This fix add Lumen v5.5 compatibility support, and do not break Lumen v5.4 support.

[jgrossi]

@krisanalfa can you merge this PR? it's really useful :-)

[Barry-Fisher]

I second this - Please merge this PR

For now as a workaround I have used the diff from this PR via the composer-patches package:

composer require cweagans/composer-patches

and added this to composer.json:

    "extra": {
        "patches": {
            "flipbox/lumen-generator": {
                "fix Lumen v5.5 compatiblity: https://github.com/flipboxstudio/lumen-generator/pull/17": "https://github.com/flipboxstudio/lumen-generator/commit/c80803f8a57494a3f0f81de072e2878b00f7711c.patch"
            }
        }
    },

then removed the lumen-generator package:

rm -Rf vendor/flipbox/lumen-generator/

and finally added it back with:

composer update --prefer-source flipbox/lumen-generator

The patch is successfully applied if you see something like:

Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing flipbox/lumen-generator (5.4.3): Cloning 93e6647bf2 from cache
  - Applying patches for flipbox/lumen-generator
    https://github.com/flipboxstudio/lumen-generator/commit/c80803f8a57494a3f0f81de072e2878b00f7711c.patch (fix Lumen v5.5 compatiblity: https://github.com/flipboxstudio/lumen-generator/pull/17)

Generating optimized autoload files

Note: I was still getting an issue with php artisan route:list but I'll raise a separate issue for that and link over once done. UPDATE: Here's the separate issue: #19

[jgrossi]

@barryrld for now, I'm using @joelhy's branch :-)

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/joelhy/lumen-generator"
    }
],
"require-dev": {
    "flipbox/lumen-generator": "dev-fix/lumen5.5_compatiblity",
},

[Barry-Fisher]

Thanks @jgrossi! I've updated my composer.json to use @joelhy's dev branch as you suggested.

I've created a new issue for the php artisan route:list issue here: #19

[joelhy]

@barryrld @jgrossi
I have fixed artisan route:list Lumen v5.5 compatiblity.

[aqidd]

Hi @joelhy thanks a lot for your contributions on this project.
Currently we don't have that much manpower to maintain this repository. Would you like to be a collaborator?

Cheers

[joelhy]

@aqidd
Yes, it's my pleasure to contribute to this project.

[aqidd]

Thanks!!