Default authZ server with role bindings API and provider integration #56

aayustark007-fk · 2023-11-20T06:52:40Z

Role Bindings Update API
AuthZ for update API for Role Bindings (need help)
Calling AuthZ server from Default provider
Tests for AuthZ server
Tests for integration of provider with server

github-actions · 2023-11-21T18:40:56Z

Test Results

173 tests 173 ✅ 32s ⏱️
40 suites 0 💤
40 files 0 ❌

Results for commit 00fd97c.

♻️ This comment has been updated with latest results.

…hing of test-fixtures

codecov-commenter · 2023-11-22T06:37:20Z

Codecov Report

Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (d1431ef) 69.63% compared to head (00fd97c) 67.18%.

Files	Patch %	Lines
...m/flipkart/varadhi/web/v1/authz/AuthZHandlers.java	32.09%	54 Missing and 1 partial ⚠️
...m/flipkart/varadhi/web/routes/RouteDefinition.java	0.00%	17 Missing ⚠️
...lipkart/varadhi/entities/auth/RoleBindingNode.java	0.00%	11 Missing ⚠️
...in/java/com/flipkart/varadhi/VerticleDeployer.java	36.36%	5 Missing and 2 partials ⚠️
...va/com/flipkart/varadhi/services/AuthZService.java	85.10%	4 Missing and 3 partials ⚠️
...ipkart/varadhi/entities/auth/IAMPolicyRequest.java	0.00%	4 Missing ⚠️
.../java/com/flipkart/varadhi/entities/auth/Role.java	0.00%	4 Missing ⚠️
...n/java/com/flipkart/varadhi/utils/LoaderUtils.java	33.33%	3 Missing and 1 partial ⚠️
...art/varadhi/auth/DefaultAuthorizationProvider.java	98.78%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
- Coverage     69.63%   67.18%   -2.45%     
- Complexity      374      424      +50     
============================================
  Files            88       93       +5     
  Lines          1696     1923     +227     
  Branches        108      124      +16     
============================================
+ Hits           1181     1292     +111     
- Misses          478      586     +108     
- Partials         37       45       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aayustark007-fk · 2023-11-22T11:52:03Z

authz/build.gradle

-dependencies {
-    implementation(project(':common'))
+components.java.withVariantsFromConfiguration(configurations.testFixturesApiElements) {
+    skip()


required to prevent publishing test-fixtures artefacts

can this be moved to publish conventions at common place ? also add above comment to the code itself.

when I add this to conventions, the build starts failing as it is not able to recognise the testFixturesApiElements configurations

aayustark007-fk · 2023-11-22T11:52:26Z

authz/src/main/java/com/flipkart/varadhi/authz/AuthorizationProvider.java


 public interface AuthorizationProvider {
-    Future<Boolean> init(AuthorizationOptions authorizationOptions);
+    Future<Boolean> init(Vertx vertx, AuthorizationOptions authorizationOptions);


required for webclient

we can use Vertx.vertx() but can that cause issues?

Not sure about using the same vertx instance here because as - it will be tuned for server usage, how using it would outside server impact it, lifecycle of it would be controlled by server, if dependents start storing it's reference will that be any issue ?, possible to avoid having vertx reference in the interfaces.

aayustark007-fk · 2023-11-22T11:53:35Z

common/build.gradle

@@ -1,5 +1,5 @@
 plugins {
-    id 'com.flipkart.varadhi.java-published-library-conventions'
+    id 'com.flipkart.varadhi.java-library-conventions'


authz does not depend on common anymore, so no need to publish this

entities/src/main/java/com/flipkart/varadhi/auth/RoleBindingNode.java

aayustark007-fk · 2023-11-22T11:56:55Z

server/src/main/java/com/flipkart/varadhi/VerticleDeployer.java


    public void deployVerticle(
            Vertx vertx,
            ServerConfiguration configuration
+    ) {
+        if (configuration.isDefaultAuthorizationServerEnabled()) {
+            deployDefaultAuthZVerticle(vertx, configuration);


deploying as a separate verticle will not cause issues with roundrobin

have tested locally

This will create two independent http servers with their own routers. Any advantage of this pattern over combining routes in single router/server.

mainly thinking from pov of isolation
if not needed then we can have it as part of single router

…topic under correct tenant and namesapce when running tests

kmrdhruv · 2023-11-27T05:12:34Z

authz/build.gradle

-dependencies {
-    implementation(project(':common'))
+components.java.withVariantsFromConfiguration(configurations.testFixturesApiElements) {
+    skip()


can this be moved to publish conventions at common place ? also add above comment to the code itself.

kmrdhruv · 2023-11-27T05:35:26Z

authz/src/main/java/com/flipkart/varadhi/authz/AuthorizationProvider.java


 public interface AuthorizationProvider {
-    Future<Boolean> init(AuthorizationOptions authorizationOptions);
+    Future<Boolean> init(Vertx vertx, AuthorizationOptions authorizationOptions);


Not sure about using the same vertx instance here because as - it will be tuned for server usage, how using it would outside server impact it, lifecycle of it would be controlled by server, if dependents start storing it's reference will that be any issue ?, possible to avoid having vertx reference in the interfaces.

kmrdhruv · 2023-11-27T05:36:43Z

buildSrc/src/main/groovy/com.flipkart.varadhi.java-published-library-conventions.gradle

@@ -15,6 +14,8 @@ publishing {

            pom {
                name = "${project.name}"
+                description = "Common AuthZ Provider interface for integrating with Varadhi"


This is common convention file, it should avoid module specific references ?

kmrdhruv · 2023-11-27T05:38:49Z

core/build.gradle

@@ -6,6 +6,7 @@ plugins {
 dependencies {
    implementation(project(':common'))
    implementation(project(':entities'))
+    implementation(project(':authz'))


i think core shouldn't depend on authz module/project.

Ya. no module will depend on it in gradle.

this is due to the usage of ResourceType enum which belongs to authz module

kmrdhruv · 2023-11-27T05:50:23Z

core/src/main/java/com/flipkart/varadhi/spi/db/MetaStore.java

@@ -1,5 +1,6 @@
 package com.flipkart.varadhi.spi.db;

+import com.flipkart.varadhi.auth.RoleBindingNode;


To be discussed:
in my view we should keep authz entities/interfaces separate from the core varadhi entities/interfaces and contain them with in authz module as these are optional components ?
Also in terms of module structure core/common/entities should not take dependency on authz, but authz can take a dependency on them as needed.

+1. separate interface.

I tried separating this out but it will lead to introduction of zookeeper dependencies in VerticleDeployer.
Otherwise, we will have to follow the metastore provider pattern for AuthZ too which will involve quite a lot of changes.

kmrdhruv · 2023-11-27T17:40:34Z

server/src/main/java/com/flipkart/varadhi/services/DefaultAuthZService.java

+import java.util.HashMap;
+import java.util.List;
+
+public class DefaultAuthZService {


AuthzService or iamService or something equivalent ?

kmrdhruv · 2023-11-27T17:41:40Z

server/src/main/java/com/flipkart/varadhi/services/DefaultAuthZService.java

+        return node;
+    }
+
+    public List<RoleBindingNode> getAllRoleBindingNodes() {


Why is this needed ? I mean any use cases which needs all role binding nodes ?

this is mainly for debug purposes

kmrdhruv · 2023-11-27T17:44:19Z

server/src/main/java/com/flipkart/varadhi/services/DefaultAuthZService.java

+        return metaStore.getRoleBindingNodes();
+    }
+
+    public RoleBindingNode getRoleBindingNode(String resourceId) {


would iampolicy better instead of RoleBindingNode ?

kmrdhruv · 2023-11-27T17:46:08Z

server/src/main/java/com/flipkart/varadhi/services/DefaultAuthZService.java

+        }
+        RoleBindingNode existingNode = metaStore.getRoleBindingNode(resourceId);
+        if (existingNode.getResourceType() != resourceType) {
+            throw new InvalidOperationForResourceException(String.format(


invalidArgument ?

kmrdhruv · 2023-11-27T17:51:52Z

server/src/test/java/com/flipkart/varadhi/auth/DefaultAuthorizationProviderTest.java

+
+    @Test
+    public void testNotInit() {
+        Assertions.assertThrows(InvalidConfigException.class, () ->


would it be invalidConfig for not initialized ?

common/src/main/java/com/flipkart/varadhi/exceptions/NotInitializedException.java

gauravAshok · 2023-12-14T10:35:38Z

entities/build.gradle

@@ -3,6 +3,7 @@ plugins {
 }
 dependencies {
    implementation(project(":common"))
+    implementation(project(":authz"))


you can remove it.

this is due to dependency on ResourceType which is used in RoleBindingNode entity

entities/src/main/java/com/flipkart/varadhi/auth/RoleBindingNode.java

…into def-authz-server

gauravAshok · 2023-12-27T09:47:42Z

entities/src/main/java/com/flipkart/varadhi/entities/auth/RoleBindingNode.java

+    public RoleBindingNode(
+            @JsonProperty("resourceId") String resourceId,
+            @JsonProperty("resourceType") ResourceType resourceType,
+            @JsonProperty("subjectToRolesMapping")


why not name it rolesAssignment?

this to indicate that the map keys are subject names, otherwise there can be confusion whether its subject to roles mapping or vice versa

a documentation should be able to clear that up.
"rolesAssignment" is more natural in phrasing. "subjectToRolesMapping" is explicit in how we are representing it. I usually prefer the former.
Just my opinion.

common/src/main/java/com/flipkart/varadhi/Constants.java

gauravAshok · 2023-12-27T09:51:57Z

core/src/main/java/com/flipkart/varadhi/spi/db/MetaStore.java

+    List<RoleBindingNode> getRoleBindingNodes();
+
+    RoleBindingNode findRoleBindingNode(String resourceIdWithType);
+
+    RoleBindingNode getRoleBindingNode(ResourceType resourceType, String resourceId);
+
+    void createRoleBindingNode(RoleBindingNode node);
+
+    boolean checkRoleBindingNodeExists(ResourceType resourceType, String resourceId);
+
+    int updateRoleBindingNode(RoleBindingNode node);
+
+    void deleteRoleBindingNode(ResourceType resourceType, String resourceId);


Lets keep the roleBindings methods in a separate interface.
RoleBindingMetaStore.java?

And have the VaradhiMetaStore implement both MetaStore & RoleBindingMetaStore.

Now, any metastore provider that wants to be able to support roleBinding storage as well, can add all interfaces in its implementation.

And our server module can just check, if the authz default is to be used, then metaStore class must be an instance of RoleBindingMetaStore.class as well, otherwise that is a hard failure, and server wont come up.

gauravAshok · 2023-12-27T09:55:47Z

core/src/main/java/com/flipkart/varadhi/spi/db/MetaStore.java

+
+    void createRoleBindingNode(RoleBindingNode node);
+
+    boolean checkRoleBindingNodeExists(ResourceType resourceType, String resourceId);


Suggested change

boolean checkRoleBindingNodeExists(ResourceType resourceType, String resourceId);

boolean isRoleBindingPresent(ResourceType resourceType, String resourceId);

Also, does "node" word have a significance? What if we just say roleBinding(s)?

gauravAshok · 2023-12-27T13:08:41Z

authz/src/testFixtures/java/com/flipkart/varadhi/entities/TestUser.java

@@ -1,5 +1,7 @@
 package com.flipkart.varadhi.entities;


Suggested change

package com.flipkart.varadhi.entities;

package com.flipkart.varadhi.authz;

Or move it to entities module itself.

server/src/main/java/com/flipkart/varadhi/web/v1/authz/AuthZHandlers.java

gauravAshok · 2023-12-27T16:38:08Z

server/src/main/java/com/flipkart/varadhi/web/v1/authz/AuthZHandlers.java

+    public Handler<RoutingContext> setIAMPolicyHandler(ResourceType resourceType) {
+        return (routingContext) -> {
+            String resourceId = routingContext.getResourceIdFromPath(resourceType);
+            IAMPolicyRequest policyForSubject = routingContext.body().asPojo(IAMPolicyRequest.class);


IAMPolicyRequest looks like can go to entities module.
entities.auth package.

gauravAshok · 2023-12-27T16:40:24Z

server/src/main/java/com/flipkart/varadhi/web/Extensions.java

@@ -98,5 +102,19 @@ public static <T> T getApiResponse(RoutingContext ctx) {
        public static void todo(RoutingContext context) {
            throw new NotImplementedException("Not Implemented.");
        }
+
+        public static String getResourceIdFromPath(RoutingContext ctx, ResourceType resourceType) {


as suggested elsewhere, this method can be moved to AuthzHandler only.

gauravAshok · 2023-12-27T16:47:39Z

server/src/main/java/com/flipkart/varadhi/config/ServerConfiguration.java

@@ -28,6 +28,7 @@ public class ServerConfiguration {

    private AuthorizationOptions authorization;

+    private boolean authorizationServerEnabled;


can we make it implicit.
Can server be disabled, if I configure DefaultAuthorizationProvider as the authzProvider?

server goes in with the default provider, without that there is no way to set the role assignments

so we will have to do the reverse, if default auth provider is enabled, server is enabled by default

so we will have to do the reverse, if default auth provider is enabled, server is enabled by default

Ya I meant this only. If this is the case, then we should go implicit. One less config.

server/src/test/java/com/flipkart/varadhi/auth/DefaultAuthorizationProviderTest.java

gauravAshok · 2023-12-27T16:59:12Z

The authz handlers are marked authenticated, but they dont have authz checks. Based on your description, anything pending there?

aayustark007-fk · 2023-12-28T13:05:14Z

The authz handlers are marked authenticated, but they dont have authz checks. Based on your description, anything pending there?

I have to add new resource type IAM_POLICY so that I can process authorization for set/get IAM policy api. This I plan to do in a follow-up PR

Signed-off-by: aayustark007-fk <aayush.gupta@flipkart.com>

gauravAshok · 2023-12-29T12:55:54Z

So, what is pending in this PR?

…tly enabled if default provider is loaded

aayustark007-fk · 2023-12-29T14:43:19Z

So, what is pending in this PR?

I have pushed all the requested changes, this PR is ready to be merged.
One remaining point is on enabling permissions authorization on authZ handlers but I rather keep it as a separate PR as it will require me to introduce new elements to ResourceType and ResourceAction enums and their handling might warrant further discussion.

aayustark007-fk

need to do these changes as part of separate PR

core/src/main/java/com/flipkart/varadhi/spi/db/RoleBindingMetaStore.java

server/src/main/java/com/flipkart/varadhi/auth/DefaultAuthorizationProvider.java

entities/src/main/java/com/flipkart/varadhi/entities/auth/RoleBindingNode.java

server/src/main/java/com/flipkart/varadhi/auth/DefaultAuthorizationProvider.java

server/src/main/java/com/flipkart/varadhi/web/v1/authz/AuthZHandlers.java

server/src/main/java/com/flipkart/varadhi/services/AuthZService.java

aayustark007-fk · 2024-01-02T11:17:45Z

server/src/testE2E/java/com/flipkart/varadhi/DefaultAuthZProviderTests.java

@@ -0,0 +1,327 @@
+package com.flipkart.varadhi;


add integration with existing org, team, etc crud flows (as other PR)
all varadhi apis are authorized if enabled

to allow authn to work either go the token way or impl default/fake authn provider to take identity from headers being passed.

kmrdhruv

LGTM,
As discussed, some pending refactoring will be taken as part of next PR.

kmrdhruv · 2023-12-08T12:44:47Z

server/src/main/java/com/flipkart/varadhi/VerticleDeployer.java

@@ -51,6 +54,7 @@ public class VerticleDeployer {
    private final OrgHandlers orgHandlers;
    private final TeamHandlers teamHandlers;
    private final ProjectHandlers projectHandlers;
+    private final Supplier<AuthZHandlers> authZHandlersSupplier;


Why wrap in Supplier ? Any specific uses being looked at ? Also handlers implement RouteProvider, which is already a supplier.

kmrdhruv · 2023-12-08T12:53:19Z

server/src/main/java/com/flipkart/varadhi/auth/DefaultAuthorizationProvider.java

+            this.configuration =
+                    YamlLoader.loadConfig(
+                            authorizationOptions.getConfigFile(), DefaultAuthorizationConfiguration.class);
+            this.webClient = WebClient.create(Vertx.vertx()); //CachingWebClient.create(WebClient.create(Vertx.vertx()));


Let's implement Cache independently in a separate task. Cache needed here should have better control in terms of how entries are cached/evicted, metrics being emitted. WebClient cache is unlikely to fit here.

kmrdhruv · 2023-12-08T12:59:30Z

server/src/main/java/com/flipkart/varadhi/auth/DefaultAuthorizationProvider.java

-                .anyMatch(pair -> isAuthorizedInternal(userContext.getSubject(), action, pair.getValue()));
-        return Future.succeededFuture(result);
+        List<Future<Boolean>> futures =
+                leafToRootResourceIds.stream().filter(pair -> StringUtils.isNotBlank(pair.getValue()))


pair.getValue() will not be empty ? Filter on isNotBlank() needed on stream ?

kmrdhruv · 2023-12-08T13:14:11Z

server/src/main/java/com/flipkart/varadhi/auth/DefaultAuthorizationProvider.java

+                )
+                .as(BodyCodec.json(RoleBindingNode.class))
+                .send()
+                .compose(response -> {


Since this is colocated with server, can we avoid webclient and instead directly use metastore. Was this ruled out ?

RoleBindingNode, could be large. Here data specific to a user is needed. Is it intended to store the entire node policy ?

kmrdhruv · 2023-12-08T13:15:19Z

server/src/main/java/com/flipkart/varadhi/auth/DefaultAuthorizationProvider.java

+                    if (node == null || node.subjectToRolesMapping == null) {
+                        return Future.failedFuture("No roles on resource for subject" + subject);
+                    }
+                    log.info(


log.debug might be better, info would be excessive here as this will be for each produce call.

kmrdhruv · 2023-12-11T05:22:28Z

server/src/main/java/com/flipkart/varadhi/services/AuthZService.java

+            return createRoleBindingNode(resourceId, resourceType);
+        }
+        RoleBindingNode existingNode = metaStore.getRoleBindingNode(resourceType, resourceId);
+        if (existingNode.getResourceType() != resourceType) {


given resource type & existence validation happens prior, is this expected ? if yes, when ?

kmrdhruv · 2023-12-11T05:23:15Z

server/src/main/java/com/flipkart/varadhi/services/AuthZService.java

+        };
+    }
+
+    private void checkValidRoles(RoleBindingNode node) {


Let's implement this, this would prevent users to store random strings as roles.

kmrdhruv · 2023-12-11T05:33:13Z

server/src/main/java/com/flipkart/varadhi/services/AuthZService.java

+        return node;
+    }
+
+    public List<RoleBindingNode> getAllRoleBindingNodes() {


This would be heavy API as it would return all role bindings across the entire hierarchy and might be an issue w/o pagination etc (which might be tough to implement on top of zk) ? If it is needed for testing, lets move it to test code itself.

kmrdhruv · 2023-12-11T05:56:31Z

common/src/main/java/com/flipkart/varadhi/Constants.java

@@ -11,6 +11,8 @@ public static class PathParams {
        public static final String REQUEST_PATH_PARAM_TEAM = "team";
        public static final String REQUEST_PATH_PARAM_PROJECT = "project";
        public static final String REQUEST_PATH_PARAM_TOPIC = "topic";
+        public static final String REQUEST_PATH_PARAM_RESOURCE = "resource";


Given the new API path implemented, are these still needed ?

kmrdhruv · 2023-12-11T05:59:28Z

common/src/main/java/com/flipkart/varadhi/exceptions/NotInitializedException.java

+import lombok.experimental.StandardException;
+
+@StandardException
+public class NotInitializedException extends VaradhiException {


Though not related to this PR, you want to modify other init providers as well to use this instead of InvalidStateException ?

aayustark007-fk and others added 8 commits November 3, 2023 23:27

add default authz verticle

1f9a9e3

add crud for roles api

f3278a5

add crud for role assignment api

243b8c1

changes to auth provider contract, now passing vertx object as 1st arg

d6a909d

add calls to authz server for default provider

29063fa

Merge branch 'master' into def-authz-server

74c4115

remove role api, now driven through static config

96ea41c

use config in web client instead of hardcoding values

91ff221

move default authz provider classes to server module, and skip publis…

012bac0

…hing of test-fixtures

aayustark007-fk added 3 commits November 22, 2023 14:07

rename rbs to bindings

db98e92

add authz handlers test

87f2ac9

add unit tests for authz service

35f30cb

aayustark007-fk commented Nov 22, 2023

View reviewed changes

entities/src/main/java/com/flipkart/varadhi/auth/RoleBindingNode.java Outdated Show resolved Hide resolved

aayustark007-fk commented Nov 22, 2023

View reviewed changes

add e2e tests and their fixes

406be01

aayustark007-fk changed the title ~~<wip> Default authZ server with roles API~~ Default authZ server with role bindings API and provider integration Nov 22, 2023

aayustark007-fk added 6 commits November 22, 2023 19:56

optimistic cleanup

3cb6897

static before after all

1c44757

rename org to public and project to default to allow creating pulsar …

0fb6101

…topic under correct tenant and namesapce when running tests

map authz port in docker compose

442ac2b

fix tests

ed59ffe

handle async setup

27097b1

kmrdhruv requested changes Nov 27, 2023

View reviewed changes

aayustark007-fk added 2 commits November 29, 2023 10:26

refactor e2e test to separate the cases as each method

4a87050

make authz server part of main rest api

00eed75

aayustark007-fk added 2 commits December 6, 2023 20:31

disable caching for get iam policy response

b8612d0

remove debug logging

a769976

aayustark007-fk mentioned this pull request Dec 13, 2023

Implement API for Default AuthZ provider to provision and modify permissions #54

Closed

Merge branch 'master' into def-authz-server

c1915c2

gauravAshok reviewed Dec 14, 2023

View reviewed changes

common/src/main/java/com/flipkart/varadhi/exceptions/NotInitializedException.java Outdated Show resolved Hide resolved

gauravAshok reviewed Dec 14, 2023

View reviewed changes

entities/src/main/java/com/flipkart/varadhi/auth/RoleBindingNode.java Outdated Show resolved Hide resolved

aayustark007-fk added 2 commits December 17, 2023 20:43

remove not initialized exception, use illegalstate exception instead

3202734

rolebinding node private final fields

e7727e7

flipkart-incubator deleted a comment from AayuStark007 Dec 17, 2023

aayustark007-fk and others added 5 commits December 22, 2023 09:23

Merge branch 'master' into def-authz-server

c33f68b

fix build gradle post master merge

810ab4b

remove vertx web client, add more tests

55f5133

Merge branch 'master' of https://github.com/flipkart-incubator/varadhi …

98d78ab

…into def-authz-server

fix e2e tests

b777a99

gauravAshok requested changes Dec 27, 2023

View reviewed changes

aayustark007-fk added 2 commits December 28, 2023 18:42

address pr comments

8452b22

Signed-off-by: aayustark007-fk <aayush.gupta@flipkart.com>

separate role binding metastore methods to separate interface

4f20ebf

aayustark007-fk added 2 commits December 29, 2023 19:56

rename subjectToRoleBinding field

497754f

remove config authorizationServerEnabled, rather it should be implici…

d5c535d

…tly enabled if default provider is loaded

enable authorization so that e2e tests work

00fd97c

aayustark007-fk commented Jan 2, 2024

View reviewed changes

kmrdhruv approved these changes Jan 2, 2024

View reviewed changes

aayustark007-fk merged commit 52bae47 into master Jan 2, 2024
2 checks passed

		@@ -1,5 +1,6 @@
		package com.flipkart.varadhi.spi.db;

		import com.flipkart.varadhi.auth.RoleBindingNode;


		void createRoleBindingNode(RoleBindingNode node);

		boolean checkRoleBindingNodeExists(ResourceType resourceType, String resourceId);

	boolean checkRoleBindingNodeExists(ResourceType resourceType, String resourceId);
	boolean isRoleBindingPresent(ResourceType resourceType, String resourceId);

	package com.flipkart.varadhi.entities;
	package com.flipkart.varadhi.authz;

		@@ -28,6 +28,7 @@ public class ServerConfiguration {

		private AuthorizationOptions authorization;

		private boolean authorizationServerEnabled;

Default authZ server with role bindings API and provider integration #56

Default authZ server with role bindings API and provider integration #56

Conversation

aayustark007-fk commented Nov 20, 2023 • edited

github-actions bot commented Nov 21, 2023 • edited

Test Results

codecov-commenter commented Nov 22, 2023 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gauravAshok commented Dec 27, 2023

aayustark007-fk commented Dec 28, 2023

gauravAshok commented Dec 29, 2023

aayustark007-fk commented Dec 29, 2023

aayustark007-fk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kmrdhruv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aayustark007-fk commented Nov 20, 2023 •

edited

github-actions bot commented Nov 21, 2023 •

edited

codecov-commenter commented Nov 22, 2023 •

edited