-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading beahvior with boolean
#746
Comments
This is intentional. I think it would be more confusing to disable and go back to a state of partial enablement than the current behavior. If you want to go back in time an audit log with rollbacks is probably best. I usually recommend enabling 100% of the time if you want to save your state. You can always turn that off and would revert to the partially enabled states. |
Hey John, I hear you but this still does not make sense. If you want the behavior you said, then Regardless of the desired behavior, the API itself is inconsistent right now and it is really not in an obvious way. And at the very minimum, the documentation does not accurately describe the behavior. |
Agreed. They should be cleared on enable too. I'm not remembering why they aren't. I'll make an issue. |
flipper.enable "foo"
does a Boolean enable of a feature.flipper.disable "foo"
destroys every enablement record including actors and groups.There are also no examples of how to actually disable the boolean version in the docs anywhere.
Suggestions:
enable
too. Lower pri, but I think it would be worthwhile.disable_all
method for the current behaviorThe text was updated successfully, but these errors were encountered: