Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny actor gate #618

Closed
wants to merge 7 commits into from
Closed

Commits on Mar 29, 2022

  1. Addability for gates to be deniable

    This will help us expand in the idea of a "DeniedActor" gate, where we are actually denying access of a feature to a specific set of users
    rafaeelaudibert committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    b6219d2 View commit details
    Browse the repository at this point in the history
  2. AddDeniedActor gate

    This gate will be responsible for holding the state of denied actors. When calling `Flipper.deny_actor(actor)` we want to be able to deny access of an actor to a resource, overriding any permission this actor might have to see a feature.
    rafaeelaudibert committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    c601fbc View commit details
    Browse the repository at this point in the history
  3. Add DeniedActor to the UI

    Now we can properly deny actors access to our code through the UI
    rafaeelaudibert committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    51d3cd1 View commit details
    Browse the repository at this point in the history
  4. Add DeniedActor handling

    This is the de facto implementation of the DeniedActor behavior. When checking if an actor has access to a feature, we first check if that user should be denied because of a deniable gate (currently, only the DeniedActorGate). If no gate is denying access, we fallback to the already existent implementation.
    rafaeelaudibert committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    bd90bb6 View commit details
    Browse the repository at this point in the history
  5. Update adapters to suport DeniedActorGate

    Some adapters had to be changed to support this new type of gate
    rafaeelaudibert committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    811e000 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Configuration menu
    Copy the full SHA
    60e38f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92b0dd2 View commit details
    Browse the repository at this point in the history