Rack 3 #670
Merged
Rack 3 #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't fully test until rack 3 is in rails.
|
|
When is this expected to get merged? |
|
Whenever Rack 3 support lands in Rails. See rails/rails#46594 |
|
Potentially related, let me know if this should be a separate issue -- is it possible to relax the |
|
It looks like Rails edge is not supporting Rack 3: rails/rails#48460 |
|
the mentioned issue on rails was solved/merged, anything still in the way to get rack 3 support? |
* v1.0: (170 commits) Release 0.28.3 Update changelog Remove sync interval from cloud config sync Avoid any possibility of sync writing back to remote Release v0.28.2 UI: fix path to bundled assets when mapped to a prefix Prepare for 0.28.1 Update changelog Improve performance of `color_name` function in log subscriber Update Changelog.md remove remote source from CSP. Bundle bootstrap, jquery and poppler. Add mirroring example Use new method of making logs bold Add a key_prefix option to the Redis adapter Fix typo in comment Update Changelog.md Add threadsafe: option to memory adapter Ensure memory adapter unlocked on fork Get rid of shotgun ...
|
@bkeepers YEAY!!! Thank you. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks to help with rack 3 support. There might be more but I can't actually update until rails does and its currently locked to rack 2. Once rails git supports rack 3 I can update this PR and see if tests pass.
xref #669