ActiveRecord adapter: wrap all reads/writes in with_connection
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeepers
force-pushed
the
ar-with-connection
branch
from
d499202
to
6c47b4c
Compare
This ensures the connection from the thread pool is checked back in if it wasn't already reserved for this thread. So using this adapter in a background thread won't permanently hold onto a connection that is infrequently used.
bkeepers
force-pushed
the
ar-with-connection
branch
from
6c47b4c
to
6f0d844
Compare
jnunemaker
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionPool#with_connection ensures the connection from the thread pool is checked back in if it wasn't already reserved for this thread. So using this adapter in a background thread won't permanently hold onto a connection that is infrequently used.
In a thread that already has an established connection (like web process) it will just reuse the connection.
cc @jhuber