Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gui: refactor text input module and fix debug on MacOS 12.3 #1045

Merged
merged 5 commits into from Mar 22, 2022
Merged

Gui: refactor text input module and fix debug on MacOS 12.3 #1045

merged 5 commits into from Mar 22, 2022

Conversation

skotopes
Copy link
Member

@skotopes skotopes commented Mar 21, 2022 •
edited by DrZlo13

What's new

  • Gui: refactor text input module
  • Fix broken debug with gdb on MacOS 12.3

Verification

  • Compile and upload
  • Verify TextInput module behaviour
  • On MacOS 12.3: brew bundle --verbose and verify that make debug is working

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes requested a review from DrZlo13 as a code owner March 21, 2022 12:49
@skotopes skotopes marked this pull request as draft March 21, 2022 12:49
@github-actions
Copy link

github-actions bot commented Mar 21, 2022 •
edited

Click here to flash the 1a81b35b version of this branch via WebUSB.

@skotopes skotopes marked this pull request as ready for review March 21, 2022 19:06
@skotopes skotopes changed the title Gui: refactor text input module Gui: refactor text input module and fix debug on MacOS 12.3 Mar 21, 2022
@DrZlo13 DrZlo13 merged commit 6470aa8 into dev Mar 22, 2022
@DrZlo13 DrZlo13 deleted the aku/text_input_fixes branch March 22, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZlo13 DrZlo13 DrZlo13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skotopes @DrZlo13