Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-2383, FL-2384] iButton, Desktop bug fixes #1062

Merged
merged 5 commits into from Mar 28, 2022
Merged

[FL-2383, FL-2384] iButton, Desktop bug fixes #1062

merged 5 commits into from Mar 28, 2022

Conversation

DrZlo13
Copy link
Member

@DrZlo13 DrZlo13 commented Mar 27, 2022 •
edited by skotopes

What's new

  • Correct init and emulation sequence for furi_hal_ibutton, fix FL-2383
  • Desktop: fix crash caused by invalid animation manager state, described in FL-2384

Verification

  • Execute ikey emulate cyfral 0123 twice. Make sure Flipper is not frozen.
  • Emulate iButton keys throw the GUI
  • Desktop: lock, start application throw the cli, unlock, exit application

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@DrZlo13 DrZlo13 requested a review from skotopes as a code owner March 27, 2022 19:12
@github-actions
Copy link

github-actions bot commented Mar 27, 2022 •
edited

Click here to flash the 96812f98 version of this branch via WebUSB.

@skotopes skotopes changed the title iButton HAL: correct init and emulation sequence [FL-2383, FL-2384] iButton, Desktop bug fixes Mar 28, 2022
@skotopes skotopes merged commit 425a74a into dev Mar 28, 2022
@skotopes skotopes deleted the zlo/ibutton_hal_interrupt_fix branch March 28, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DrZlo13 @skotopes