Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New frequency analyzer #1501

Closed
wants to merge 4 commits into from
Closed

New frequency analyzer #1501

wants to merge 4 commits into from

Conversation

ClusterM
Copy link

@ClusterM ClusterM commented Jul 30, 2022 •
edited
Loading

What's new

New frequency analyzer view:

  • Ability to set RSSI trigger level
  • Sound and vibration on signal detect
  • The last detected frequency is displayed
  • The interface looks better

Screenshot-20220730-213212

Verification

  • Start "Sub-GHz"
  • Select "Frequency Analyzer"
  • Check out the new Frequency Analyzer!
  • Try to generate any signal nearby
  • "Success" sound and vibration should be played
  • The last frequency value and the last RSSI level should be displayed
  • You can press left and right to set RSSI trigger level

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@ClusterM
Copy link
Author

ClusterM commented Jul 30, 2022 •
edited
Loading

Related to #1480 and #1466.

kotleni
kotleni previously approved these changes Jul 30, 2022
View reviewed changes
@Astrrra Astrrra added Sub-GHz Sub-GHz-related UI Affects UI New Feature Contains an IMPLEMENTATION of a new feature labels Jul 31, 2022
@ClusterM
Copy link
Author

I have formatted the code.

kotleni
kotleni previously approved these changes Jul 31, 2022
View reviewed changes
@ClusterM
Copy link
Author

One last minor fix: round frequency value to KHz (299999990Hz to 300000000Hz).

ppseprus
ppseprus reviewed Jul 31, 2022
View reviewed changes
applications/subghz/views/subghz_frequency_analyzer.c
@@ -20,11 +37,20 @@ struct SubGhzFrequencyAnalyzer {
SubGhzFrequencyAnalyzerCallback callback;
void* context;
bool locked;
float rssi_last;
uint32_t frequency_last;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does not solve the underlying issue.

If one is scanning a busy area, the "last" would flicker just as much as the "current", making it unreadable the same way as the existing implementation.

#opinionated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1466

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does not solve the underlying issue.

If one is scanning a busy area, the "last" would flicker just as much as the "current", making it unreadable the same way as the existing implementation.

#opinionated

No, it's updated with the last value after there is no signal for a while.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I see. Well, the last time I used c was about 15 years ago 😅
Anyhow, it would be great to reuse the subghz_history and utilize the up and down arrows to navigate in the history. What do you think?
I have been trying to do just that, but unfortunately c was really really a long time ago.. 😞

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyhow, it would be great to reuse the subghz_history and utilize the up and down arrows to navigate in the history. What do you think?

I think that it's good idea but i'm not ready to implement it now. Maybe later.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

What's the best way to contribute to the "history feature" ?
Waiting for this PR to be validated ? Forking your fork & PR to it ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

What's the best way to contribute to the "history feature" ? Waiting for this PR to be validated ? Forking your fork & PR to it ?

Not sure. Let's wait for PR to be validated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn I wish I was better at cpp! 😅

@RogueMaster

This comment was marked as abuse.

Sign in to view
@ClusterM
Copy link
Author

ClusterM commented Aug 7, 2022

I just don't want to wait. So I closed it and merged it into 3rd party branch. GitHub can't fork two projects with the same name.

@RogueMaster

This comment was marked as abuse.

Sign in to view
@ClusterM
Copy link
Author

ClusterM commented Aug 8, 2022

Created new pull request: #1557
And it's much better.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppseprus ppseprus ppseprus left review comments

@yen0p yen0p yen0p left review comments

@kotleni kotleni kotleni approved these changes

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm

Assignees
No one assigned
Labels
New Feature Contains an IMPLEMENTATION of a new feature Sub-GHz Sub-GHz-related UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ClusterM @RogueMaster @ppseprus @kotleni @yen0p @Astrrra @DrZlo13