-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic shutdown on idle #1647
base: dev
Are you sure you want to change the base?
Conversation
merge with flipperdevices
# Conflicts: # applications/power/power_service/power_i.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please format code with clang-format
applications/power/power_settings_app/scenes/power_settings_scene_shutdown_idle.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but introducing a new file in /int will take up at least 4Kb of internal storage - and we're running short on it for debug builds.
We'll discuss this feature internally and may merge it after releasing v.0.65.
Good to know this. I've been looking at adding a setting to the Power application for optionally limiting the battery charging voltage, and that would've required creating a new If this idle shutdown PR gets merged, I can base my battery charge limit configuration efforts atop this so there will be two settings stored in |
Hi flipper team, how about to merge this? We are at 0.66 already. |
Hi @azaitsev, will be included in next release. Sorry for delay. |
@SHxKenzuto May I ask you to merge dev? |
Ok, doing it right now |
@skotopes merge completed |
Thanks. This RC is already packed with more features than our QA can test, so I'll merge it after this release. |
I've built from the most recent set of commits (2022-12-18) and tested it. Overall, this is a nice feature! Testing -
|
We'll include this PR in next release(0.78). |
I need more time with this code, moving to next release. |
applications/settings/power_settings_app/scenes/power_settings_scene_shutdown_idle.c
Show resolved
Hide resolved
I think the next priority it making sure the butthurt_max xp system works off of what the clock app runs off of. Ive had issues with the butthurt_max xp not resetting properly if you turn off the flipper fully instead of locking it. If we do that, it would make this feature much more favorable in terms of preserving power by shutting it off after some time. |
Otherwise I think this option in the settings to auto-shutoff would be very useful if the butthurt thing resets when the battery isnt under regular load |
Considering the recent success of a deeper power-saving mode for the Flipper for 1 month of idle time, I think the selectable auto-shutdown delays could be adjusted. Instead of… Perhaps… Alternatively, if auto-off is no longer desired, I'd still like to make use of the Power app's settings code to add the configurable battery charge voltage limit - which with longer idle time reduces the risk of someone overdischarging. |
Seeing the recent I'm still both interested in auto-shutdown (especially if increasing the upper bound, so the Flipper shuts off after a week of not interacting with it), and in the Power application having a settings file (to build charge voltage limit settings on top of). |
@digitalcircuit I'm currently refactoring power service, I'll update this PR and then merge it. |
Could this please be merged? Currently I'm finding myself in the fairly risky situation of forgetting to use my Flipper for a while and finding my battery depleted, which lithium batteries don't like. This would ensure that an idle flipper wouldn't be at risk of killing its battery. |
Flipper will shut down itself when battery reaches 3.3V also there is a second battery protection circuit that will disconnect battery from the flipper when battery depleted below ~2.8V. Chances of killing battery is completely discharging it are quite small. Anyway, I hear you. This PR was in a limbo for a long time, I'll allocate time to refactor power service and merge this PR in next release. |
Thanks, it's good to know my Flipper won't die! Still, it would be nice to leave it semi-charged and know I can pick it up and use it months later, without needing a charge. |
I am still interested in the Power app gaining support for persistent settings, too - I haven't forgotten about the charge limiting feature that doesn't (yet!) have a GUI to control it. Thank you for not giving up on this, and definitely understood on having had other priorities. EDIT: Details on charge voltage limiting here: #1158 (comment) |
@digitalcircuit there's charge limiting? How do I enable it? |
What's new
Verification
Checklist (For Reviewer)