Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying LFRFID protocol names #1682

Closed
wants to merge 1 commit into from
Closed

Fix displaying LFRFID protocol names #1682

wants to merge 1 commit into from

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Aug 29, 2022

What's new

  • Protocols no longer have double names

Verification

  • Verify that Jablotron, Viking and Paradox are not "Jablotron Jablotron", "Viking Viking" etc. in the "Add manually" section of the LFRFID app
    CleanShot 2022-08-29 at 22 58 42@2x

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Member

@Astrrra, @nminaylov is currently rewriting RFID application in C. I can merge this PR, but then it will require backport.

@hedger hedger added RFID 125kHz 125, 134 kHz RFID UI Affects UI labels Sep 19, 2022
@skotopes
Copy link
Member

Implemented by @nminaylov in C version

@skotopes skotopes closed this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Assignees
No one assigned
Labels
RFID 125kHz 125, 134 kHz RFID UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Astrrra @skotopes @hedger