Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Quiet subgig Read and Read RAW #1745

Closed
wants to merge 1 commit into from
Closed

UX: Quiet subgig Read and Read RAW #1745

wants to merge 1 commit into from

Conversation

Himura2la
Copy link
Contributor

What's new

  • Disable flashing LED while scanning on subgig.
    • Consistent with Frequency Analyzer
    • Less suspicious when using in public places

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Himura2la Himura2la changed the title Quiet subgig Read and Read RAW UX: Quiet subgig Read and Read RAW Sep 18, 2022
@Himura2la Himura2la mentioned this pull request Sep 18, 2022
Closed
3 tasks
@skotopes
Copy link
Member

@Himura2la san, you basically can turn off led in Settings-> Notification. There is no need to disable it for everyone.
Frequency analyzer is a little bit different thing and its notification patterns is not applicable here.

@skotopes skotopes closed this Sep 18, 2022
@Himura2la
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Himura2la @skotopes