Add lockable capability to Submenu module #2289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent to break existing apps
giacomoferretti
requested review from
skotopes,
DrZlo13 and
hedger
as code owners
hedger
added
UI
|
Use cases are? |
|
One use case might be to show the user the ability to perform a certain action, but not at that time because prerequisites are required (e.g., full card reading). For example here: nfc_scene_mf_classic_menu.c#L25 The "Detect Reader" option may always be visible to inform the user that there is an opportunity to run it, but not at this time because the card has not been read. Could be useful in external apps too. |
|
Sounds like too over specialized feature. |
|
No problem! |
Willy-JL
added a commit
to Willy-JL/flipperzero-firmware
that referenced
this pull request
Apr 30, 2024
API additions: - `submenu_add_lockable_item()`: based on flipperdevices#2289 which was rejected, CFWs merged it and improved it over time, theres a few apps that use it by now (example usecase: highlighting that some features are not available in current configuration / state) - `submenu_set_orientation()`: can have vertical submenu (user's preference for ux, same concept works great in infrared app, could be reused there to make more of the app vertical instead of having to keep switching) - `variable_item_list_get()`: get and allow editing an item after creation (example usecase: editing one option changes state of other entries in the list, like if they are locked due to incompatible settings or if they have different labels or values) - `variable_item_list_set_header()`: feature parity with `submenu` widget (example usecase: headers are pretty but want editable options not just a list) - `variable_item_set_item_label()`: allow changing label after adding item (example usecase: want to show index of item, can have value shown and put (1/10) in label dynamically, also probably more, allows more creativity) - `variable_item_set_locked()`: same as above for `submenu`, based on same code but ported to varitemlist by me. also allows setting locked state after the fact, remembers locked message so after creation you can toggle with `set_locked(item, false/true, NULL)` (example usecase, some settings combinations in this screen are incompatible, like GPIO pins overlapping when configuring) General improvements: - Can have header in Variable Item List - Can have a vertical Submenu - Can lock items in Variable Item List and Submenu - Variable Item List label and value scroll if too long - Variable Item List value arrows shrink if value is < 4 characters - More freedom and usefulness in Variable Item List API - Cleaned up some parts of the code and some magic numbers are now defined Acknowlegments: - Original submenu lockable items code by @giacomoferretti in flipperdevices#2289 - Vertical submenu and some code improvements by Unleashed CFW team - Most other edits by me @Willy-JL - Hope I'm not forgetting someone else that was involved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Screenshots
Checklist (For Reviewer)