New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3374] iButton: delete key text overflow #2882

Merged

skotopes merged 2 commits into flipperdevices:dev from Programistich:programistich/3375-ibutton-delete-format

Jul 17, 2023

Contributor

Programistich commented Jul 15, 2023 •

edited by skotopes

Loading

What's new

Use widget_add_text_box_element above widget_add_string_element
Correct height for title and uid

Verification

Saved iButton key with long key
Go to Delete scene (like iButton -> saved -> Choose Key -> Delete)
See what long text not overflow

Checklist (For Reviewer)

PR has description of feature/bug or link to Confluence/Jira task
Description contains actions to verify feature/bugfix
I've built this code, uploaded it to the device and verified feature/bugfix


          IButton: on delete scene key name not fully display if so long

3e71163

Programistich requested review from skotopes, DrZlo13, hedger and gsurkov as code owners

July 15, 2023 18:59


          Merge branch 'dev' into programistich/3375-ibutton-delete-format

aa1516b

skotopes approved these changes

View reviewed changes

skotopes merged commit 9bb0483 into flipperdevices:dev

7 of 8 checks passed

hedger added Bug UI iButton labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skotopes skotopes approved these changes

DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

hedger Awaiting requested review from hedger hedger is a code owner

gsurkov Awaiting requested review from gsurkov gsurkov is a code owner