Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDX-B temperature in system units #2941

Merged
merged 3 commits into from Aug 7, 2023
Merged

FDX-B temperature in system units #2941

merged 3 commits into from Aug 7, 2023

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Aug 3, 2023 •
edited by skotopes

What's new

Verification

  • Read an FDX-B temperature tag with system units set to metric and imperial, verify that the temperature is correct and is displayed in the correct units.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited

Compiled firmware for commit f1458fb3:

@skotopes skotopes merged commit 1e4af1d into dev Aug 7, 2023
8 checks passed
@skotopes skotopes deleted the astra/fdx-imperial-temp branch August 7, 2023 10:28
agarof pushed a commit to agarof/flipperzero-firmware that referenced this pull request Aug 30, 2023
@Astrrra @skotopes @agarof
FDX-B temperature in system units (flipperdevices#2941)
3743019 
* FDX-B temperature now uses system units
* LF-RFID: wrap floats in fdx-b temperature conversion

Co-authored-by: あく <alleteam@gmail.com>
@hedger hedger added Applications Non-core applications New Feature Contains an IMPLEMENTATION of a new feature labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Applications Non-core applications New Feature Contains an IMPLEMENTATION of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings>System>Units Imperial Setting does not change RFID Temperature read reporting
3 participants
@Astrrra @skotopes @hedger