Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive: Fix item focus after aborting the Delete operation #3475

Merged

Conversation

CookiePLMonster
Copy link
Contributor

@CookiePLMonster CookiePLMonster commented Feb 23, 2024

What's new

This PR fixes a bug in the Browser where cancelling a Delete operation made the Browser focus on the first item on the list, with the Pin/Rename/Delete context menu still open. This PR fixes the focus issue, and hides the context menu when Delete is selected, so the behaviour is consistent with Rename where it was happening already.

Verification

  1. Open Browser and navigate anywhere where there are multiple items on the screen. In my test, it was apps\Games.
  2. Focus on any entry that is not the first.
  3. Select the entry and choose Delete, then Cancel.
  4. Observe that:
    • Without this PR, the context menu is still open, and the menu is focused on the top entry.
    • With this PR, the context menu is not open, and the menu is focused on the previously selected entry.

I have verified that deleting items does not break the flow and the menu remains usable (just focuses on the entry that used to be next to the deleted one).

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added Bug Core+Services HAL, furi & core system services labels Feb 26, 2024
@skotopes skotopes merged commit 5e47048 into flipperdevices:dev Mar 5, 2024
9 checks passed
@CookiePLMonster CookiePLMonster deleted the fix-archive-scene-delete-focus branch March 5, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Core+Services HAL, furi & core system services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants