Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Fix elements module for new canvas API #3527

Merged
merged 8 commits into from Mar 23, 2024

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Mar 20, 2024

What's new

  • Use signed int32_t for coordinates and bigger size_t for width/height, according to new Canvas API
  • Allows to use negative coordinates as intended by Canvas

Verification

  • Can use negative coordinates for elements functions, such as drawing elements_slightly_rounded_frame() slightly off-screen to the left

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added the Core+Services HAL, furi & core system services label Mar 20, 2024
@hedger hedger marked this pull request as draft March 20, 2024 22:25
@Willy-JL Willy-JL marked this pull request as ready for review March 20, 2024 22:30
@hedger
Copy link
Member

hedger commented Mar 20, 2024

Please also update symbols for f18 (fbt TARGET_HW=18) so that both version numbers are equal.

@Willy-JL
Copy link
Contributor Author

oh sure, my bad

skotopes
skotopes previously approved these changes Mar 21, 2024
@Willy-JL
Copy link
Contributor Author

thanks for the additional fixes, works great!

@skotopes skotopes merged commit 0a48658 into flipperdevices:dev Mar 23, 2024
10 checks passed
@Willy-JL Willy-JL deleted the gui-elements-fix branch March 23, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core+Services HAL, furi & core system services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants