Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3803] NFC: Fix mf desfire detect #3548

Merged
merged 1 commit into from Mar 29, 2024
Merged

[FL-3803] NFC: Fix mf desfire detect #3548

merged 1 commit into from Mar 29, 2024

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented Mar 28, 2024 •
edited by skotopes

What's new

  • More strict mf desfire detect function

Verification

  • Emv cards are not detected as desfire

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gornekich gornekich mentioned this pull request Mar 28, 2024
Closed
@github-actions GitHub Actions
Copy link

Compiled f7 firmware for commit 6565ab2d:

@gornekich gornekich changed the title NFC: Fix mf desfire detect [FL-3803] NFC: Fix mf desfire detect Mar 28, 2024
@skotopes skotopes merged commit 74cda02 into dev Mar 29, 2024
11 checks passed
@skotopes skotopes deleted the gornek/fix_des_false_detect branch March 29, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gornekich @skotopes