Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3746] Mifare Plus detection support #3607

Merged
merged 34 commits into from
Jun 10, 2024
Merged

[FL-3746] Mifare Plus detection support #3607

merged 34 commits into from
Jun 10, 2024
+1,655 −744

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Apr 22, 2024 •
edited by skotopes

What's new

  • Mifare Plus cards are now detected as such and can be partially read and saved

Verification

  • Read a Mifare Plus card, check that the Type, Size, and Security level are determined correctly

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Astrrra Astrrra marked this pull request as ready for review April 22, 2024 12:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited

Compiled f7 firmware for commit 07efa307:

@hedger hedger added NFC NFC-related New Feature Contains an IMPLEMENTATION of a new feature labels May 8, 2024
@gornekich gornekich self-assigned this May 14, 2024
@gornekich gornekich marked this pull request as draft May 15, 2024 11:51
@github-actions GitHub Actions
Copy link

PVS-Studio report for commit 54f63e06:

gornekich
gornekich requested changes May 21, 2024
View reviewed changes
lib/nfc/protocols/mf_plus/mf_plus_poller_i.c Outdated Show resolved Hide resolved
lib/nfc/protocols/mf_plus/mf_plus_poller.c Outdated Show resolved Hide resolved
@gornekich gornekich marked this pull request as ready for review May 30, 2024 12:57
gornekich
gornekich previously approved these changes May 30, 2024
View reviewed changes
skotopes
skotopes previously approved these changes Jun 1, 2024
View reviewed changes
@skotopes skotopes marked this pull request as draft June 3, 2024 14:35
@Astrrra Astrrra marked this pull request as ready for review June 5, 2024 09:55
@skotopes skotopes merged commit cf8c82c into dev Jun 10, 2024
11 checks passed
@skotopes skotopes deleted the astra/3746-mfp-detect branch June 10, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@gornekich gornekich gornekich left review comments

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees

@gornekich gornekich

Labels
New Feature Contains an IMPLEMENTATION of a new feature NFC NFC-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Astrrra @skotopes @gornekich @hedger