Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: Mf Desfire fix reading big files #3616

Merged
merged 7 commits into from May 14, 2024
Merged

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented Apr 25, 2024

What's new

  • Rework reading long data and record sizes
  • Limit file data rendering to 256 bytes per record

Verification

  • Create big file:
    hf mfdes formatpicc - format desfire
    hf mfdes createapp --aid 001122 - create application
    hf mfdes createfile --aid 001122 --fid 01 --amode plain --rrights free --wrights free --rwrights free --chrights free --size 001d01 - create big file
  • Read file with flipper. Verify that only 256 bytes is visible
  • Save file. Verify that all data is saved on sd card.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Copy link

github-actions bot commented Apr 25, 2024

Compiled f7 firmware for commit 23e6e300:

@hedger hedger added NFC NFC-related Bug labels May 8, 2024
@skotopes skotopes merged commit 5f9b300 into dev May 14, 2024
11 checks passed
@skotopes skotopes deleted the gornek/desfire_long_files branch May 14, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug NFC NFC-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants