Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3817] iButton: fix crash when deleting some keys #3617

Merged
merged 4 commits into from Apr 29, 2024
Merged

[FL-3817] iButton: fix crash when deleting some keys #3617

merged 4 commits into from Apr 29, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Apr 26, 2024 •
edited by skotopes

What's new

  • iButton no longer crashes when deleting Metakom or Cyfral keys

Verification

  • Delete keys of the types mentioned above, check that it works as expected

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited

Compiled f7 firmware for commit 872c4b51:

@skotopes skotopes merged commit 7414e6d into dev Apr 29, 2024
11 checks passed
@skotopes skotopes deleted the astra/3817-ibutton-crash branch April 29, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Astrrra @skotopes