Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3797] Settings menu refactoring #3632

Merged
merged 10 commits into from
May 14, 2024
Merged

[FL-3797] Settings menu refactoring #3632

merged 10 commits into from
May 14, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented May 3, 2024 •
edited by skotopes

What's new

  • Different sections of the settings menu modified, see FL-3797

Verification

  • Verify that the UI matches the intended design

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited

Compiled f7 firmware for commit 81f59493:

@Astrrra Astrrra marked this pull request as ready for review May 3, 2024 10:15
@Astrrra Astrrra marked this pull request as draft May 6, 2024 09:48
@Astrrra Astrrra marked this pull request as ready for review May 7, 2024 09:56
@hedger hedger added the UI Affects UI label May 8, 2024
@skotopes skotopes merged commit e3f95a3 into dev May 14, 2024
11 checks passed
@skotopes skotopes deleted the astra/3797-settings-refactoring branch May 14, 2024 18:58
@Astrrra Astrrra mentioned this pull request May 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Astrrra @skotopes @hedger