Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra lfrfid protocol implementation #3640

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

Leptopt1los
Copy link
Contributor

@Leptopt1los Leptopt1los commented May 7, 2024

What's new

Electra intercom (Romania) lfrfid protocol implementation
Solves #1500 and https://forum.flipper.net/t/electra-intercom/6368

Verification

  • Write to t5577 random em4100
  • to blocks 3-4 write 0x7E71AAAA 0xAAAAAAAA
  • set maxblck to 4
    OR
  • Go to lfrfid -> extra actions -> add manually -> Electra Group Electra
  • Fill with random data, but set last 3 bytes as 7E 71 AA
  • Save the dump, write to t5577
    OR
  • Get original Electra intercom tag
    OR
  • Use ask raw dump emulation on another flipper zero

AND read the tag. Must be detected as Electra Group Electra

After this:

  • Test reading, writing to t5577 and emulation (read with pm3/another flipper zero)
  • Test regression on EM4100 tags

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added RFID 125kHz 125, 134 kHz RFID New Feature Contains an IMPLEMENTATION of a new feature labels May 8, 2024
Copy link
Member

@DrZlo13 DrZlo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works, no regressions, but I don't have the original Electra cards.
It also appears that proxmark does not know this protocol.

Anyway, good job, I think this is a good place to start.

@DrZlo13 DrZlo13 merged commit a86aefa into flipperdevices:dev May 14, 2024
10 of 11 checks passed
@d3xt3r01
Copy link

@skotopes Works. I found a small issue. On latest dev now. After a power off/on the info shows epilogue as 00000000... After an emulation info shows the correct epilogue again.

@skotopes
Copy link
Member

@Leptopt1los wanna add fix to this RC? or next one?)

@Leptopt1los
Copy link
Contributor Author

@skotopes can fix it tomorrow. just need to trigger ‎protocol_electra_encoder_start in render method before printf. or print epilogue directly from decoded data (a faster, but smellier solution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature Contains an IMPLEMENTATION of a new feature RFID 125kHz 125, 134 kHz RFID
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants