Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3846] Event Loop Timers #3721

Merged
merged 52 commits into from
Jul 2, 2024
Merged

[FL-3846] Event Loop Timers #3721

merged 52 commits into from
Jul 2, 2024

Conversation

gsurkov
Copy link
Member

@gsurkov gsurkov commented Jun 18, 2024 •
edited by skotopes
Loading

What's new

  • Add software timer functionality to FuriEventLoop
  • Add a test blinky application
  • Refactor the Dolphin application

Verification

  1. Connect 6 LEDs to pins 2-7 on Flipper (use series resistors of course)
  2. Flash the firmware first and then run the test application: ./fbt launch APPSRC=event_loop_blink_test
  3. Observe the blinkenlights! Each button on the Flipper can stop or start a particular LED. Press and hold Back to exit.
  4. Speed up the Dolphin: compile with --extra-define=DOLPHIN_DEBUG, observe the messages in the log.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gsurkov
Implement POC event loop tmers (not all edge cases are handled)
dfe17f5
@gsurkov
Use a separate ready list to allow for (re)starting and stopping of t…
5dd2a27 
…imers from callback
@gsurkov
Improve the test application
a7cdc2d
@gsurkov
Improve timer API and test application
ed0837c
@gsurkov
Merge remote-tracking branch 'origin/dev' into gsurkov/3846_event_loo…
e85b126 
…p_timers
@gsurkov
Improve timeout calculation logic
7b01f77
@gsurkov
Improve timer API, update documentation
7ead695
@gsurkov
Fix API usage error
09aef56
@gsurkov
Update doxygen comments
8c05da6
@gsurkov
Revert the old (correct) check
8fcc2b2
@gsurkov
Improve function naming
95d6c9c
@gsurkov
Check whether a timer was on the expired list before processing it
21ab696
@gsurkov
Merge remote-tracking branch 'origin' into gsurkov/3846_event_loop_ti…
3de2de0 
…mers
@gsurkov
Implement tick callback
9b9ec6b
@gsurkov
Add critical sections to improve timer consistency
6da5ee4
@gsurkov
Simplify event loop timer API
ee1df8f
@gsurkov
Remove redundant search
85b0176
@gsurkov
Refactor timer logic, use message queue
518d767
@gsurkov
Simplify FuriEventLoopTimer API
73e4c64
@gsurkov
Improve event loop timer logic
6d8076d
@gsurkov
Update the f18 target
3386ff1
@gsurkov
Merge remote-tracking branch 'origin/dev' into gsurkov/3846_event_loo…
e7a8e95 
…p_timers
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

Compiled f7 firmware for commit f324d878:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

PVS-Studio report for commit 98238827:

@gsurkov gsurkov marked this pull request as ready for review June 19, 2024 17:04
skotopes and others added 3 commits June 20, 2024 18:20
@hedger hedger added New Feature Contains an IMPLEMENTATION of a new feature Core+Services HAL, furi & core system services labels Jun 20, 2024
skotopes
skotopes reviewed Jun 21, 2024
View reviewed changes
applications/debug/event_loop_blink_test/event_loop_blink_test.c Outdated Show resolved Hide resolved
targets/f18/api_symbols.csv Show resolved Hide resolved
targets/f7/api_symbols.csv Show resolved Hide resolved
furi/core/event_loop.c Show resolved Hide resolved
furi/core/event_loop.c Show resolved Hide resolved
gsurkov and others added 15 commits June 21, 2024 16:22
@gsurkov
Bump API version
23cc4ce
@skotopes
Merge remote-tracking branch 'origin/dev' into gsurkov/3846_event_loo…
b95a0b7 
…p_timers
@skotopes
Debug: multiple of 25 timings in event loop blink test
68d281d
@gsurkov
Separate FuriEventLoopTimer to its own set of files
7a466bb
@gsurkov
Improve start time calculation for periodic timers
2318435
@gsurkov
Merge branch 'dev' into gsurkov/3846_event_loop_timers
e323a4b
@skotopes
Merge remote-tracking branch 'origin/dev' into gsurkov/3846_event_loo…
fb3448a 
…p_timers
@gsurkov
Do not use dynamic allocations for timer requests
6dca1df
@gsurkov
Split the tick functionality in separate files, rearrange code
eaa708d
@gsurkov
Improve timer queue handling
364c6ff
@gsurkov
Properly reset GPIO pins in the test app
3b16af3
@gsurkov
Properly initialise GPIO pins in the test app too
fe5582d
@gsurkov
Merge branch 'dev' into gsurkov/3846_event_loop_timers
9cf5242
@skotopes
Furi: variable naming in event loop
938581c
@skotopes
Furi: fix spelling in event loop
f324d87
@skotopes skotopes merged commit 139660d into dev Jul 2, 2024
11 checks passed
@skotopes skotopes deleted the gsurkov/3846_event_loop_timers branch July 2, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CookiePLMonster CookiePLMonster CookiePLMonster left review comments

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services New Feature Contains an IMPLEMENTATION of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gsurkov @skotopes @CookiePLMonster @hedger