New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3831] Separate editing and renaming in iButton and LFRFID #3735

Merged

skotopes merged 2 commits into dev from astra/3831-ibutton-rfid-edit-rename

Jun 30, 2024

Member

Astrrra commented Jun 25, 2024 •

edited by skotopes

Loading

What's new

Edit and Rename are now two different menu items

Verification

Mess around with renaming files and check that it behaves as expected
Edit files and check that everything gets changed properly

Checklist (For Reviewer)

PR has description of feature/bug or link to Confluence/Jira task
Description contains actions to verify feature/bugfix
I've built this code, uploaded it to the device and verified feature/bugfix


          Separate editing and renaming in iButton and LFRFID

4c3db8d

Astrrra requested review from skotopes, DrZlo13, hedger and gsurkov as code owners

June 25, 2024 12:07

github-actions bot commented Jun 25, 2024 •

edited

Loading

Compiled f7 firmware for commit 5eed90d2:


          Merge branch 'dev' into astra/3831-ibutton-rfid-edit-rename

5eed90d

skotopes approved these changes

View reviewed changes

skotopes merged commit 81e2736 into dev

11 checks passed

skotopes deleted the astra/3831-ibutton-rfid-edit-rename branch

June 30, 2024 11:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skotopes skotopes approved these changes

DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

hedger Awaiting requested review from hedger hedger is a code owner

gsurkov Awaiting requested review from gsurkov gsurkov is a code owner