Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: storage: minor subcommand lookup refactor #3739

Merged
merged 2 commits into from
Jun 30, 2024
Merged

cli: storage: minor subcommand lookup refactor #3739

merged 2 commits into from
Jun 30, 2024

Conversation

hedger
Copy link
Member

@hedger hedger commented Jun 30, 2024 •
edited by skotopes
Loading

What's new

  • cli: removed explicit iteration over each command
  • cli: storage: unified handler CLI signature
  • cli: better formatting for "storage" help screen
  • saving some space in flash with more compact code

Verification

  • run various storage CLI commands
  • install update over USB

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2024 •
edited
Loading

Compiled f7 firmware for commit 080d0a4c:

@hedger hedger marked this pull request as ready for review June 30, 2024 14:44
@hedger hedger changed the title cli: storage: internal subcommand handler signature unification cli: storage: minor subcommand lookup refactor Jun 30, 2024
@hedger hedger added the Core+Services HAL, furi & core system services label Jun 30, 2024
@skotopes skotopes merged commit 14b37a6 into dev Jun 30, 2024
11 checks passed
@skotopes skotopes deleted the hedger/storage_cli_cleanup branch June 30, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hedger @skotopes