Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-1696, FL-1685] IRDA: Add RC5, decoder refactoring #663

Merged
merged 6 commits into from
Aug 20, 2021
Merged

[FL-1696, FL-1685] IRDA: Add RC5, decoder refactoring #663

merged 6 commits into from
Aug 20, 2021

Conversation

albkharisov
Copy link
Contributor

@albkharisov albkharisov commented Aug 20, 2021 •
edited

What's new

  • Add RC5, RC5X protocols
  • Refactoring in encoders-decoders: now there are 1 encoder-decoder for several protocols (e.g. NEC, NECext)

Verification

  • Run IRDA CLI, try to send/receive RC5, RC5X (address is 5 bit length, command is 6 bit length)

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Albert Kharisov added 5 commits August 19, 2021 11:30
[FL-1696] IRDA: Split decoders and protocols
d8c7220 
There are protocols (NEC/NECext, RC5/RC5X) which are similar but
has slight difference. They can be decoded by one decoder.
Split them to occupy less space and save RAM.
IRDA: Restruct directories
161900a 
Move irda_common* -> common/
IRDA: fix long timings
020b562
[FL-1685] IRDA: Add RC5
44842c9
Merge remote-tracking branch 'origin/dev' into alb_fl_1696_encoder_de…
b5265a7 
…coder_refactoring
@skotopes skotopes merged commit e6d5f40 into dev Aug 20, 2021
@skotopes skotopes deleted the alb_fl_1696_encoder_decoder_refactoring branch August 20, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albkharisov @skotopes