Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix git.mk & post a quick flash link on PR builds #670

Merged
merged 5 commits into from
Aug 26, 2021
Merged

CI: Fix git.mk & post a quick flash link on PR builds #670

merged 5 commits into from
Aug 26, 2021

Conversation

aprosvetova
Copy link
Contributor

@aprosvetova aprosvetova commented Aug 24, 2021 •
edited

What's new

  • Fixed git.mk for pull requests
  • The quick flash link is posted and updated on every pull request build

Verification

  • Check the link in the comment
  • Short sha must be correct and same in filename and CFLAGS
  • Branch name must be correct and the same in filename and CFLAGS

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Aug 24, 2021 •
edited

Click here to flash the 264a560 version of this branch via WebUSB.

@aprosvetova aprosvetova force-pushed the ktq_ci-magic branch 2 times, most recently from 3162d55 to cca82ba Compare August 24, 2021 15:01
@aprosvetova aprosvetova changed the title CI: Post a quick flash link on pull request builds CI: Fix git.mk & post a quick flash link on PR builds Aug 24, 2021
@aprosvetova aprosvetova marked this pull request as ready for review August 24, 2021 15:09
skotopes
skotopes previously approved these changes Aug 26, 2021
View reviewed changes
@skotopes skotopes merged commit 08f7a29 into dev Aug 26, 2021
@skotopes skotopes deleted the ktq_ci-magic branch August 26, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aprosvetova @skotopes