Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive: fix delete from favorites tab #752

Merged
merged 6 commits into from
Oct 12, 2021
Merged

Archive: fix delete from favorites tab #752

merged 6 commits into from
Oct 12, 2021

Conversation

itsyourbedtime
Copy link
Contributor

@itsyourbedtime itsyourbedtime commented Oct 7, 2021 •
edited

What's new

  • Fix wrong file path when deleting item from "Favorites" tab in archive
  • Removed redundant carriage return when appending string to file
  • Sorting items in "Favorites" tab with new "Move" option

Verification

  • Build, flash
  • Deletion from "Favorites" tab should work correctly
  • favorites.txt contains no empty lines when viewed on PC

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Oct 7, 2021 •
edited

Click here to flash the 178a763f version of this branch via WebUSB.

@skotopes skotopes merged commit 5cb5d15 into dev Oct 12, 2021
@skotopes skotopes deleted the archive_fix_favdelete branch October 12, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsyourbedtime @skotopes