Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-1920] Fix NTAG emulation #776

Merged
merged 3 commits into from
Oct 21, 2021
Merged

[FL-1920] Fix NTAG emulation #776

merged 3 commits into from
Oct 21, 2021

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented Oct 19, 2021 •
edited

What's new

  • Always read signature if reading version was successful

Verification

  • Verify signature is saved for NTAG cards
  • Verify correct NXP public key in Nfc tools Pro while emulating mifare ultralight

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Oct 19, 2021 •
edited

Click here to flash the 8453329e version of this branch via WebUSB.

@skotopes skotopes merged commit af1fd0c into dev Oct 21, 2021
@skotopes skotopes deleted the gornek/1920_ntag_signature_emulation branch October 21, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gornekich @skotopes