Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-2047] SubGhz: New GUI ReadRAW view #832

Merged
merged 8 commits into from
Nov 24, 2021
Merged

[FL-2047] SubGhz: New GUI ReadRAW view #832

merged 8 commits into from
Nov 24, 2021

Conversation

Skorpionm
Copy link
Member

@Skorpionm Skorpionm commented Nov 19, 2021 •
edited by jira bot

What's new

  • FL-2047 SubGhz: New GUI RAW Read view
  • SubGhz: fix bug wrong frequency of the allowed transmission

Verification

  • Compile and download the firmware
  • Download the Sub Ghz Read RAW application, and check if it works

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Nov 19, 2021 •
edited

Click here to flash the c610759f version of this branch via WebUSB.

@github-actions
Copy link

Please fix following code formatting errors:

./applications/subghz/scenes/subghz_scene_need_saving.c:9:43: error: code should be clang-formatted [-Wclang-format-violations]
        view_dispatcher_send_custom_event(
                                          ^
./applications/subghz/scenes/subghz_scene_need_saving.c:12:43: error: code should be clang-formatted [-Wclang-format-violations]
        view_dispatcher_send_custom_event(
                                          ^

You might want to run docker compose exec dev /syntax_check.sh for an auto-fix.

@github-actions
Copy link

Please fix following code formatting errors:

./applications/subghz/scenes/subghz_scene_need_saving.c:9:43: error: code should be clang-formatted [-Wclang-format-violations]
        view_dispatcher_send_custom_event(
                                          ^
./applications/subghz/scenes/subghz_scene_need_saving.c:12:43: error: code should be clang-formatted [-Wclang-format-violations]
        view_dispatcher_send_custom_event(
                                          ^

You might want to run docker compose exec dev /syntax_check.sh for an auto-fix.

@skotopes skotopes mentioned this pull request Nov 23, 2021
Closed
@Skorpionm Skorpionm changed the title SubGhz: GUI RAW Read view [FL-2047] SubGhz: New GUI RAW Read view Nov 23, 2021
@Skorpionm Skorpionm marked this pull request as ready for review November 23, 2021 16:12
@Skorpionm Skorpionm changed the title [FL-2047] SubGhz: New GUI RAW Read view [FL-2047] SubGhz: New GUI ReadRAW view Nov 23, 2021
@skotopes skotopes self-requested a review November 23, 2021 17:22
skotopes
skotopes requested changes Nov 23, 2021
View reviewed changes
applications/subghz/views/subghz_read_raw.c Outdated
i + 2,
32 + subghz_read_raw_tab_sin((i + model->ind_sin * 16 + 1) * 2) /
SUBGHZ_RAW_SIN_AMPLITUDE);
// canvas_draw_line(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

applications/subghz/views/subghz_read_raw.c Outdated
string_reset(model->preset_str);
string_reset(model->sample_write);
free(model->rssi_history);
//string_reset(model->frequency_str);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@skotopes skotopes merged commit a13f87f into dev Nov 24, 2021
@skotopes skotopes deleted the skorp/gui_raw_raad branch November 24, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Skorpionm @skotopes