Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of screen drawings #842

Merged
merged 9 commits into from
Nov 26, 2021
Merged

Fix out of screen drawings #842

merged 9 commits into from
Nov 26, 2021

Conversation

albkharisov
Copy link
Contributor

@albkharisov albkharisov commented Nov 25, 2021

What's new

  • Fix lock screen menu falling out of screen bounds
  • Fix pin setup falling out of screen bounds

Verification

  • Run lock screen menu
  • Run pin setup on lock screen

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Nov 25, 2021

Click here to flash the ad4fa1a0 version of this branch via WebUSB.

@github-actions
Copy link

Please fix following code formatting errors:

./applications/desktop/views/desktop_first_start.c:41:26: error: code should be clang-formatted [-Wclang-format-violations]
        canvas_draw_icon(
                         ^
./applications/desktop/views/desktop_first_start.c:46:26: error: code should be clang-formatted [-Wclang-format-violations]
        canvas_draw_icon(
                         ^
./applications/desktop/views/desktop_first_start.c:69:26: error: code should be clang-formatted [-Wclang-format-violations]
        canvas_draw_icon(
                         ^
./applications/desktop/views/desktop_first_start.c:74:26: error: code should be clang-formatted [-Wclang-format-violations]
        canvas_draw_icon(
                         ^

You might want to run docker compose exec dev /syntax_check.sh for an auto-fix.

@skotopes skotopes merged commit 3ab9112 into dev Nov 26, 2021
@skotopes skotopes deleted the alb/fix_lock_screen branch November 26, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants