Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build for Python versions <3.9 #855

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

fominykhandrei
Copy link
Contributor

@fominykhandrei fominykhandrei commented Nov 30, 2021

What's new

  • Fix the following build issue on Ubuntu 20.04:
  File "./scripts/meta.py", line 52, in merge
    full |= dict
TypeError: unsupported operand type(s) for |=: 'dict' and 'dict'
make: *** [Makefile:17: all] Error 1

The merge (|) and update (|=) operators for dictionaries were introduced in Python 3.9 so they do not work in older versions. Use an equivalent

Verification

  • Compile

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@aprosvetova
Copy link
Contributor

lgtm

@skotopes skotopes merged commit 9fc7fe7 into flipperdevices:dev Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants