Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rpc: StorageInfo, StorageRename, SystemReboot, SystemDeviceInfo (bonus: +FuriHalInfo) #862

Merged
merged 10 commits into from
Dec 7, 2021
Merged

Rpc: StorageInfo, StorageRename, SystemReboot, SystemDeviceInfo (bonus: +FuriHalInfo) #862

merged 10 commits into from
Dec 7, 2021

Conversation

aprosvetova
Copy link
Contributor

@aprosvetova aprosvetova commented Dec 3, 2021 •
edited

What's new

  • Renamed RpcStatus to RpcSystem
  • Implemented StorageInfoRequest
  • Implemented StorageRenameRequest
  • Implemented SystemRebootRequest
  • Introduced FuriHalInfo which handles the device info logic now
  • Implemented SystemDeviceInfoRequest
  • Minor refactoring here and there

Verification

  • Please proceed to comments
  • My PRs are easy to inspect commit-by-commit btw

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited

Click here to flash the a6e0e0a8 version of this branch via WebUSB.

@aprosvetova
Copy link
Contributor Author

StorageInfo, StorageRename, and SystemReboot are finished and covered with tests, but the PR is in a draft state cause I'm waiting for Monday to get advice from @skotopes and implement SystemDeviceInfo in the same branch.

@aprosvetova aprosvetova changed the title Rpc: StorageInfo, StorageRename, SystemReboot Rpc: StorageInfo, StorageRename, SystemReboot, DeviceInfo (bonus: +FuriHalInfo) Dec 6, 2021
@aprosvetova aprosvetova marked this pull request as ready for review December 6, 2021 15:50
@aprosvetova aprosvetova changed the title Rpc: StorageInfo, StorageRename, SystemReboot, DeviceInfo (bonus: +FuriHalInfo) Rpc: StorageInfo, StorageRename, SystemReboot, SystemDeviceInfo (bonus: +FuriHalInfo) Dec 6, 2021
@aprosvetova
Copy link
Contributor Author

You can use flipper-new-rpc-darwin-amd64.zip to test new RPC requests.

./flipper-new-rpc-darwin-amd64 /dev/tty...

@skotopes skotopes merged commit 03d7476 into dev Dec 7, 2021
@skotopes skotopes deleted the ktq/rpc_inflation branch December 7, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aprosvetova @skotopes