Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-2198], [FL-2161] NFC emulation refactoring #968

Merged
merged 21 commits into from
Feb 2, 2022
Merged

[FL-2198], [FL-2161] NFC emulation refactoring #968

merged 21 commits into from
Feb 2, 2022

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented Jan 26, 2022 •
edited by skotopes

What's new

  • Show reader commands in UID emulation mode
  • New nfc emulation approach
  • Fix bt settings unintended switch to forget devices scene

Verification

  • Verify flipper displays reader commands in UID emulation
  • Verify Mifare Ultralight emulation works as usual

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gornekich gornekich marked this pull request as draft January 26, 2022 10:30
@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited

Click here to flash the 82259dd4 version of this branch via WebUSB.

@gornekich gornekich marked this pull request as ready for review January 27, 2022 12:15
@gornekich gornekich changed the title Gornek/2198 nfc emulation logger [FL-2198], [FL-2161] NFC emulation refactoring Jan 27, 2022
@skotopes skotopes self-requested a review January 27, 2022 13:41
skotopes
skotopes requested changes Jan 27, 2022
View reviewed changes
Copy link
Member

@skotopes skotopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emulation is broken.

@gornekich gornekich marked this pull request as draft February 2, 2022 12:03
@gornekich gornekich marked this pull request as ready for review February 2, 2022 18:11
@skotopes skotopes merged commit 8cfd0ea into dev Feb 2, 2022
@skotopes skotopes deleted the gornek/2198_nfc_emulation_logger branch February 2, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gornekich @skotopes