Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata): authenticate /meta endpoints #1250

Merged
merged 3 commits into from Jan 3, 2023
Merged

Conversation

GeorgeMac
Copy link
Contributor

Fixes FLI-119

This moves the following endpoints behind the gRPC authentication middleware:

  • /meta/config
  • /meta/info

This ensures when authentication is required that this information is not leaked.

To achieve this, the core implementation of these endpoints has been moved into a gRPC service of its own.
Such that it can be easily integrated in with the gRPC authentication middleware that exists.

This is done using gRPC gateways support for *runtime.HttpBody.

Screenshot 2023-01-02 at 13 47 41

Screenshot 2023-01-02 at 13 48 35

@GeorgeMac GeorgeMac requested a review from a team as a code owner January 2, 2023 14:11
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Merging #1250 (22dc7fb) into main (d00b9aa) will not change coverage.
The diff coverage is n/a.

❗ Current head 22dc7fb differs from pull request most recent head 86d4320. Consider uploading reports for the commit 86d4320 to get more accurate results

@@           Coverage Diff           @@
##             main    #1250   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          41       41           
  Lines        3150     3150           
=======================================
  Hits         2527     2527           
  Misses        501      501           
  Partials      122      122           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@GeorgeMac GeorgeMac merged commit b3fc4b1 into main Jan 3, 2023
@GeorgeMac GeorgeMac deleted the gm/metadata-protect branch January 3, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants