Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tag/push latest for now #1290

Merged
merged 1 commit into from
Jan 23, 2023
Merged

chore: remove tag/push latest for now #1290

merged 1 commit into from
Jan 23, 2023

Conversation

markphelps
Copy link
Collaborator

the change in #1182 broke the creation of the docker multi-arch manifest, since tagging/pushing via docker via the CLI only tags and pushes the image for the architecture on which its run

this requires us to then go back and manually fix the latest tag to be the correct multiarch manifest

Im proposing we remove this stage for now until we come up with a better solution of properly creating / pushing multiarch manifests only if this is the latest semantic verison

@markphelps markphelps requested a review from a team as a code owner January 23, 2023 18:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Merging #1290 (681211c) into main (5f96f1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   79.88%   79.88%           
=======================================
  Files          43       43           
  Lines        3267     3267           
=======================================
  Hits         2610     2610           
  Misses        527      527           
  Partials      130      130           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps merged commit 6e8b423 into main Jan 23, 2023
@markphelps markphelps deleted the rm-tag-latest branch January 23, 2023 19:51
markphelps added a commit that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants