Otel improvements #1306
Otel improvements #1306
Conversation
* main: fix: disable csp headers in non-release mode for ui dev (#1304)
| - "14250:14250" | ||
| - "14268:14268" | ||
| - "14269:14269" | ||
| - "9411:9411" |
There was a problem hiding this comment.
Jaeger is so greedy with ports
internal/server/otel/attributes.go
Outdated
| AttributeMatch = attribute.Key("flipt.match") | ||
| AttributeFlag = attribute.Key("flipt.flag") | ||
| AttributeFlagEnabled = attribute.Key("flipt.flag_enabled") | ||
| AttributeSegment = attribute.Key("flipt.segment") | ||
| AttributeReason = attribute.Key("flipt.reason") | ||
| AttributeValue = attribute.Key("flipt.value") | ||
| AttributeEntityID = attribute.Key("flipt.entity_id") | ||
| AttributeRequestID = attribute.Key("flipt.request_id") | ||
| AttributeDurationMS = attribute.Key("flipt.duration_ms") |
There was a problem hiding this comment.
Food for thought: going forward I wonder if we can reconcile these: https://github.com/flipt-io/flipt/blob/main/internal/server/metrics/metrics.go#L54-L60
For now, I dont think it is worth it. Just a shame as there is some overlap.
I wish I had namespaced those metrics.go ones like you have.
There was a problem hiding this comment.
yeah i thought about that, the only difference right now is the namespace I think
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1306 +/- ##
==========================================
+ Coverage 79.92% 80.09% +0.17%
==========================================
Files 43 43
Lines 3272 3300 +28
==========================================
+ Hits 2615 2643 +28
Misses 527 527
Partials 130 130
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* main: chore: bump prom verison (#1305) Otel improvements (#1306) fix: disable csp headers in non-release mode for ui dev (#1304) chore(deps): bump go.opentelemetry.io/otel/exporters/jaeger (#1299) chore(deps): bump google.golang.org/grpc from 1.52.0 to 1.52.3 (#1303) feat(logging): support custom time, level and message keys (#1295) fix: get linter running correctly locally (#1296) chore(deps): bump go.opentelemetry.io/otel from 1.11.2 to 1.12.0 (#1301) chore(deps): bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1298)
Fixes: FLI-194
Adds some telemetry span attributes for the
EvaluateandGetFlagendpoints