Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new log keys to config schemas #1313

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Conversation

markphelps
Copy link
Collaborator

Re: #1252

@markphelps markphelps requested a review from a team as a code owner February 2, 2023 15:30
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick improvements listed otherwise this looks great!

config/flipt.schema.cue Outdated Show resolved Hide resolved
config/flipt.schema.cue Outdated Show resolved Hide resolved
markphelps and others added 2 commits February 2, 2023 10:49
Co-authored-by: George <me@georgemac.com>
Co-authored-by: George <me@georgemac.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #1313 (9685d29) into main (18c4557) will decrease coverage by 0.19%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
- Coverage   80.37%   80.19%   -0.19%     
==========================================
  Files          43       43              
  Lines        3307     3307              
==========================================
- Hits         2658     2652       -6     
- Misses        518      522       +4     
- Partials      131      133       +2     
Impacted Files Coverage Δ
internal/storage/oplock/sql/sql.go 90.82% <0.00%> (-5.51%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps enabled auto-merge (squash) February 2, 2023 15:52
@markphelps markphelps merged commit 0af41e9 into main Feb 2, 2023
@markphelps markphelps deleted the config-schema-updates branch February 2, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants