feat/proposal: Deprecate jaeger enabled

[markphelps]

Fixes: FLI-197
Fixes: #1310

Deprecates tracing.jaeger.enabled in favor of:

tracing:
  enabled: true
  backend: jaeger

[codecov-commenter]

Codecov Report

Merging #1316 (2d9b8ad) into main (0af41e9) will increase coverage by 0.41%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
+ Coverage   80.37%   80.78%   +0.41%     
==========================================
  Files          43       43              
  Lines        3307     3331      +24     
==========================================
+ Hits         2658     2691      +33     
+ Misses        518      512       -6     
+ Partials      131      128       -3     

Impacted Files	Coverage Δ
internal/config/config.go	88.83% <ø> (ø)
internal/config/deprecations.go	100.00% <ø> (ø)
internal/config/cache.go	100.00% <100.00%> (ø)
internal/config/tracing.go	100.00% <100.00%> (ø)
internal/server/flag.go	81.92% <100.00%> (+3.61%)	⬆️
internal/server/rule.go	76.92% <100.00%> (+3.84%)	⬆️
internal/server/segment.go	79.16% <100.00%> (+4.16%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[GeorgeMac]

Suggested change

	enabled?: bool | *false
	exporter?: "jaeger" | *"jaeger"
	enabled: bool | *false
	exporter: "jaeger" | *"jaeger"

I think you can forgo making this optional if there is a default.

[GeorgeMac]

Actually with exporter you might be able to get away with just:

exporter?: jaeger

Which just says if you specify the key exporter it must be the value "jaeger".
And drop the default.

[markphelps]

i'll prob just leave this as is for now since we will very shortly allow others besides jaeger

[GeorgeMac]

Nice. One observation that I am not 💯 is necessary.

[markphelps]

@GeorgeMac I'm wondering if we should change exporter to be collector or maybe something more agnostic like backend or consumer ? backend might be nice as it mimics what we have in the cache config as well.

Looking at OTel's glossary, it seems to me that:

• exporter is actually the library used to send the traces
• collector seems specific to their OTLP implementation

WYT?

[GeorgeMac]

@markphelps I like your reasoning there. backend sounds good. Other ideas could be destination or target.
But I like backend just as much.

[GeorgeMac]

Sweet.